Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to resize Launchers on touch screens #16061

Open
martaszmit opened this issue Mar 26, 2024 · 5 comments
Open

Not possible to resize Launchers on touch screens #16061

martaszmit opened this issue Mar 26, 2024 · 5 comments
Labels

Comments

@martaszmit
Copy link

martaszmit commented Mar 26, 2024

Description

I tried to use JupyterLab (browser version) on my tablet (Microsoft Surface Pro 9), but it is not possible to resize Launchers using touch. It works fine using mouse.

Reproduce

Add multiple Launchers and try to resize it.
image

Expected behavior

Resizing should be possible on touch screens like it is when using mouse.

Context

@martaszmit martaszmit added the bug label Mar 26, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Mar 26, 2024
Copy link

welcome bot commented Mar 26, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

That's odd, since lumino 2.0 (included in JupyterLab 4.x) we are using pointer events rather than mouse events so it should no longer be the case.

https://jupyter.org/try-jupyter/lab/

As of today this is using JupyterLab 4.0.11.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Mar 26, 2024
@JasonWeill
Copy link
Contributor

Curious whether this also occurs in Lab 4.1 or 4.2 alpha.

@martaszmit
Copy link
Author

It works much better on my iPad, but doesn't work on my Windows devices. Not sure how about Android, because I don't have any device to test it. It also doesn't work in browser developer tools while simulating touch.

@krassowski
Copy link
Member

It also doesn't work in browser developer tools while simulating touch.

Right, I can reproduce this. I see that there is something off with pointer events for handlers in lumino, but do not immediately see what is wrong. Maybe we should use https://developer.mozilla.org/en-US/docs/Web/API/Element/setPointerCapture API, not sure how much it would help though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants