Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher has unused optional factory dependency #16165

Closed
krassowski opened this issue Apr 15, 2024 · 2 comments · Fixed by #16173
Closed

Launcher has unused optional factory dependency #16165

krassowski opened this issue Apr 15, 2024 · 2 comments · Fixed by #16173
Assignees
@milinm
Labels
bug good first issue

Comments

@krassowski
Copy link
Member

jupyterlab/packages/launcher-extension/src/index.ts

Line 65 in 62dcce8

factory: IFileBrowserFactory | null

Is not used in the activate function. I think it should have been removed in #13786 which refactored the extension to use the default browser instead.
@krassowski krassowski added bug good first issue status:Needs Triage Applied to new issues that need triage labels Apr 15, 2024
@milinm
Copy link
Contributor

milinm commented Apr 15, 2024

Hi, I am a student looking to work on a good first issue. May I have this issue assigned to me?

@krassowski krassowski assigned krassowski and milinm and unassigned krassowski Apr 15, 2024
@krassowski
Copy link
Member Author

Please do @milinm.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Apr 16, 2024
@JasonWeill JasonWeill mentioned this issue Apr 16, 2024
Open
@krassowski krassowski linked a pull request Apr 17, 2024 that will close this issue
Remove unused IDefaultFileBrowser dependency from launcher-extension #16173
Merged
@krassowski krassowski mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milinm milinm

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused IDefaultFileBrowser dependency from launcher-extension milinm/jupyterlab
3 participants
@krassowski @milinm @JasonWeill