Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify discussion about fileeditor settings #2382

Closed
ellisonbg opened this issue Jun 7, 2017 · 1 comment
Closed

Unify discussion about fileeditor settings #2382

ellisonbg opened this issue Jun 7, 2017 · 1 comment
Labels
enhancement pkg:fileeditor status:Needs Discussion status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@ellisonbg
Copy link
Contributor

We have a number of other issues about the fileeditor settings. We now have a formal settings system for persisting global settings and I wanted to create a new issue that summarizes things in one place.

Here is a list of possible fileeditor settings and its current status.

  • Line numbers (global setting)
  • Word wrap (global setting)
  • Match brackets (global setting)
  • Keybinding (global setting)
  • Theme (global setting)
  • Tabs versus spaces (missing)
  • How many spaces (missing)
  • Syntax highlight language (missing)

Reality of our current approach: we don't yet have a way of having settings for languages (python, C/C++, JS, etc.) so we have to live with a simplified version of things.

Questions:

  • Which of these things should be global settings versus per editor?
  • Should we try to save the per editor settings (maybe by path?) or just forget when the file is closed.

Marking as beta as the lack of some of these things currently makes some file types impossible to work with in lab (Makefiles).

@ellisonbg
Copy link
Contributor Author

Fixed for now we in master.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:fileeditor status:Needs Discussion status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

1 participant