Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Browser's Native Context Menu More Discoverable #4023

Closed
saulshanabrook opened this issue Feb 26, 2018 · 9 comments
Closed

Make Browser's Native Context Menu More Discoverable #4023

saulshanabrook opened this issue Feb 26, 2018 · 9 comments

Comments

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Feb 26, 2018

Right now the fact that SHIFT right-click brings up the browser's context menu is not obvious. It wasn't until I read I comment about it that I realized it was possible. Others have had the same confusion (#3011 (comment), #3911 (comment)).

It is explained in the JupyterLab docs already, so it might make sense to describe the functionality in the interface somehow. One option would be to include some text in the existing JupyterLab context menu that says something like "Use SHIFT right-click to access the system context menu..."

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 14, 2018

This is coming up somewhat frequently, so triaging to beta 3 for at least starting a design discussion.

Loading

@mangecoeur
Copy link

@mangecoeur mangecoeur commented Apr 20, 2018

Perhaps its worth thinking about what people are needing the shift-click for. I suspect its mostly people looking for the 'save image as' menu. I think it would be good to add a 'save image' option to the context menu where appropriate, since that's probably what people actually want.

Loading

@fperez
Copy link
Contributor

@fperez fperez commented Apr 21, 2018

+1 to @mangecoeur's point - even if there's better discoverability for shift-click in general, I suspect a direct 'save image' entry will cover the vast majority of needs.

Loading

@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Apr 21, 2018

I want the native browser context menu to copy/paste text in the terminal. I want to copy and paste stuff in the terminal all the time but have never (yet) wanted to save an image.

While I'm here I'll put in a plug for @stephenakearns' feature request to make selecting text in the terminal also copy the text - or at least a setting to enable such.

Loading

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 7, 2018

In #4660, @stefanv also wants copying of a URL as a common operation.

Loading

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 7, 2018

I think that should be pretty doable using the jp-RenderedHTML selector.

Loading

@jasongrout jasongrout removed this from the Beta 3 milestone Jun 27, 2018
@jasongrout jasongrout added this to the Beta 4 milestone Jun 27, 2018
@blink1073 blink1073 removed this from the 0.34 milestone Aug 13, 2018
@blink1073 blink1073 added this to the 0.35 milestone Aug 13, 2018
@blink1073 blink1073 removed this from the 0.35 milestone Sep 5, 2018
@blink1073 blink1073 added this to the 1.0 milestone Sep 5, 2018
@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Nov 14, 2018

Just to revive this conversation, it seems if we add 'save image' and 'Copy/paste' to notebook output and terminal context menus (respectively) this would solve the lion's portion of this issue. Does anybody have any other examples of times they were trying to surface the browser context menu?

Loading

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 14, 2018

Save Link as..., Copy Link location, open the developer tools inspecting an element are several other menu items I use.

Loading

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Nov 20, 2018

@jasongrout I also use those frequently, but primarily in the context of developing Jupyter Lab, not using it. I think adding useful tools for 'doing data science' ought to be a separate discussion from tools for 'developing jupyterlab'.

As long as the shift-right-click is documented clearly in the developer documentation I think it's covered for the "I'm developing JupyterLab" crowd.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

8 participants