Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only one shortcut per command #423

Closed
to266 opened this issue Jul 16, 2016 · 3 comments
Closed

only one shortcut per command #423

to266 opened this issue Jul 16, 2016 · 3 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@to266
Copy link

to266 commented Jul 16, 2016

It seems that currently the shortcuts only support one per command (hence #320 J/K in the notebook are not easily possible)

this commit would ideally add the shortcuts, but since they are higher than the original (arrow) ones, the arrow shortcuts get ignored.

Looks like the commands are a hash table... Alternatively I'm not adding things correctly (and should have added directly to the sequence somehow?)..


edit:
relevant part of the phosphide
https://github.com/phosphorjs/phosphide/blob/master/src/services/shortcutregistry.ts#L50

@blink1073
Copy link
Member

blink1073 commented Jul 16, 2016

Hi @to266, this behavior is fixed in the new consolidated phosphor repo, which we will be switching over to in the next week or so.

@jasongrout
Copy link
Contributor

@blink1073 - done?

@blink1073
Copy link
Member

Yep, fixed by #591.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants