Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quit button to exit JupyterLab #4647

Closed
fcollonval opened this issue May 26, 2018 · 1 comment
Closed

Add Quit button to exit JupyterLab #4647

fcollonval opened this issue May 26, 2018 · 1 comment
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@fcollonval
Copy link
Member

For the classical Notebook, a Quit button has been introduced to shutdown the Notebook server
(see jupyter/notebook#3004).

I though this is a good addition to make Jupyterlab behave more closely to a desktop app. But for other use cases (like online installation) this is probably a bad thing - I presume this is the reason for the newly introduced parameter NotebookApp.shutdown_button. But as my web-development skills are small, I for now has implemented it as an extension https://github.com/fcollonval/jupyterlab_quit. But for consistency with the classical notebook, it's a nice to have.

Nota: I may try to set a PR if somebody can point me how I could condition UI elements on config parameters.

@fcollonval
Copy link
Member Author

Done in #5226. To be available in 0.35

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants