Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Chrome App Mode experience #5755

Open
PEERCRED opened this issue Dec 11, 2018 · 3 comments
Open

Improve Chrome App Mode experience #5755

PEERCRED opened this issue Dec 11, 2018 · 3 comments

Comments

@PEERCRED
Copy link

In App Mode, Chrome is more tolerant to key interceptions.
For example, Ctrl-W works in a terminal as expected (deletes previous word) instead of closing the browser tab. But outside of a terminal it still closes the window.

I propose to intercept this (and some other) shortcut by default in JupyterLab with or without an action bound to it.

@jasongrout
Copy link
Contributor

Thanks. Wouldn't it confuse users more if Ctrl-W didn't close the app, though?

What are the other keyboard shortcuts you think should be intercepted?

@jasongrout jasongrout added this to the Future milestone Dec 11, 2018
@PEERCRED
Copy link
Author

Wouldn't it confuse users more if Ctrl-W didn't close the app, though?

IDK, but closing the current JupyterLab's tab instead of the whole browser window/tab would be more natural IMO.

What are the other keyboard shortcuts you think should be intercepted?

No other candidates now.

@jasongrout
Copy link
Contributor

Note that you can always define such a keyboard shortcut to be captured (or even close the current tab, I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants