Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of window object in coreutils. #6346

Closed
afshin opened this issue May 13, 2019 · 1 comment
Closed

Remove usage of window object in coreutils. #6346

afshin opened this issue May 13, 2019 · 1 comment

Comments

@afshin
Copy link
Member

@afshin afshin commented May 13, 2019

  • ActivityMonitor uses window.setTimeout and should just use setTimeout.
  • StateDB is dependent on window.localStorage and can be switched to an in-memory object.
  • SettingRegistry should possibly be moved out of @jupyterlab/coreutils.

cf. @vidartf

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants