Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow notebook tools to affect multiple cells. #6797

Open
markellekelly opened this issue Jul 9, 2019 · 6 comments
Open

Allow notebook tools to affect multiple cells. #6797

markellekelly opened this issue Jul 9, 2019 · 6 comments

Comments

@markellekelly
Copy link
Contributor

markellekelly commented Jul 9, 2019

My proposal is that we allow notebook-tools to affect multiple cells at a time.

Right now, when multiple cells are selected in a notebook, the notebook tools panel still only corresponds to the active cell, without any clear indication that it's doing so. The "Slide Type" dropdown, for example, will still allow you to select a new slide type:

image
image

But the slide type is only applied to the active cell, not the other selected cells. The second selected cell still has no slide type:

image

The expected behavior is that all selected cells are given this new cell-type. Otherwise, the notebook-tools panel should probably prevent users from changing the active cell when multiple cells are selected (e.g. gray out the slide type dropdown).

@markellekelly
Copy link
Contributor Author

@Zsailer and I came across this problem in relation to the functionality of celltags, which belongs in the notebook tools panel. The multiple selection interaction issue becomes exaggerated in celltags, where the ability to select, filter, and add tags to multiple cells at a time is what makes the extension particularly useful.

@Zsailer Zsailer changed the title Confusing interaction pattern for multiple selection in NB tools panel Allow notebook tools to affect multiple cells. Jul 9, 2019
@Zsailer
Copy link
Member

Zsailer commented Jul 9, 2019

Pinging @tgeorgeux for thoughts.

@tgeorgeux
Copy link
Contributor

I have a few thoughts, I'll try to dump these briefly.

  • I think any action that can be performed on a single cell only (such as editing cell metadata) ought to be disabled when more than one cell is selected.
  • Any operation that could reasonably affect multiple selected (such as slide type) should apply to all selected cells.
  • Notebook wide operations (such as edit notebook metadata) should remain enabled when multiple cells are selected.
  • Cell operations (run, stop, copy, etc.)should affect all selected cells.

I whole-heartedly agree that multiple cell operations should operate on all selected cells, and single-cell operations should be disabled when multiple cells are selected.

@tgeorgeux tgeorgeux added this to the 1.1 milestone Aug 12, 2019
@blink1073 blink1073 modified the milestones: 1.1, 1.2 Aug 27, 2019
@tgeorgeux tgeorgeux self-assigned this Sep 10, 2019
@tgeorgeux tgeorgeux modified the milestones: 1.2, 2.0 Sep 10, 2019
@jasongrout jasongrout modified the milestones: 2.0, 3.0 Dec 2, 2019
@tgeorgeux
Copy link
Contributor

As of now, there seems to be only one field that needs to be disabled. Here's a screenshot of the cell metadata field disabled:
Cell Tools - Advanced Options Expanded
For Styling:
/* Cell Metadata Input /
/
--jp-layout-color2 /
/
--jp-border-color1 */

/* Cell Metadata /
/
--jp-content-font-size1 /
/
--jp-ui-font-color2 */

/* N/A /
/
--jp-content-font-color2 */

One thing we should be careful of is that we don't overwrite and existing cell metadata when we add slide metadata or nbconvert metadata to cell metadata on the non-selected cells.

@jasongrout jasongrout modified the milestones: 2.0, Future, 2.1 Jan 2, 2020
@jasongrout jasongrout modified the milestones: 2.1, 3.0 Mar 12, 2020
@blink1073 blink1073 modified the milestones: 3.0, Future Aug 21, 2020
@krlng
Copy link

krlng commented Dec 9, 2020

Any updates on this? In my point of view this would make it much less cumbersome to actually use jupyterlab for presentations.

@daliagachc
Copy link

Hi! any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants