Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterHub integration - restart server & options_form #6998

Closed
clkao opened this issue Aug 13, 2019 · 1 comment
Closed

JupyterHub integration - restart server & options_form #6998

clkao opened this issue Aug 13, 2019 · 1 comment
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@clkao
Copy link

clkao commented Aug 13, 2019

Description

In #6451, the jupyterhub integration adds a dialog prompt for restarting server when the server is gone, which uses rest api to restart user server. However if the options_form feature is enabled in hub, users should be redirected to the spawner page instead.

Reproduce

in a form-enabled hub environment:

  1. Go to hub and spawn a server and visit the user lab
  2. stop the user server
  3. Click on restrart server on the prompt
  4. unexpected server is spawned, as user is not prompted with spawner options

Expected behavior

  1. Go to hub and spawn a server and visit the user lab
  2. stop the user server
  3. Click on restrart server on the prompt
  4. User gets to the spawner page in new window

Context

  • JupyterLab version: 1.0.4
@clkao
Copy link
Author

clkao commented Aug 13, 2019

This seems to be a false alarm. the spawner page is opened in blank window correctly, as per https://github.com/jupyterlab/jupyterlab/pull/6451/files#diff-e687f0ea18d10248928d4f0aeb9e3eceR65

@clkao clkao closed this as completed Aug 13, 2019
blink1073 pushed a commit to blink1073/jupyterlab that referenced this issue Aug 17, 2019
@telamonian
last fix in jupyterlab#6998: the --watch build is fixed
4d4a257 
This fixes the problem with the `--watch` build (which was caused by a
depopulation of "linkedPackages" in `dev_mode/package.json`). It still
needs a bit of cleanup work
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clkao