Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Review - Button width in File Browser. #7593

Closed
tgeorgeux opened this issue Dec 5, 2019 · 1 comment · Fixed by #8994
Closed

UX Review - Button width in File Browser. #7593

tgeorgeux opened this issue Dec 5, 2019 · 1 comment · Fixed by #8994
Assignees
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@tgeorgeux
Copy link
Contributor

Description

The icon buttons along the top of the File Browser are currently set to scale their width.

Reproduce

  1. Go to 'File Browser'
  2. Adjust the width and watch the buttons spread out.

@kgryte brought this up at the JupyterLab Dev Meeting.

Expected behavior

It's not common in Material Design, or in JupyterLab for buttons to change shape or spacing on a resize event. @ellisonbg I wasn't around yet when this was originally designed is there a reason we chose to make those button variable-width instead of pinning them to the left side? I've thought of a couple of reasons that may have been:

  • Wider buttons are easier to quickly click on.
  • Discourages adding too many icons to clutter up the main bar?
  • When working in a notebook, the buttons widening out makes some of them closer to the main work area.

Examples of similar button layouts that don't change size or position on resize:

  • Command Palette
  • Notebook Toolbar
  • Running Pane
  • Menu Bar

In short, I think we should treat the button similar to the notebook toolbar and pin them the left side at a set width (which we may want to keep a little wider than the notebook toolbar buttons).

Context

  • Operating System and version: Any
  • Browser and version: Any
  • JupyterLab version: Any
@tgeorgeux
Copy link
Contributor Author

I think we should give the buttons a max width of 32 and left align them.

@telamonian telamonian self-assigned this Jan 8, 2020
@jasongrout jasongrout modified the milestones: 2.0, 2.1 Jan 22, 2020
@jasongrout jasongrout modified the milestones: 2.1, 3.0 Mar 12, 2020
@ellisonbg ellisonbg self-assigned this Sep 8, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants