New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The app shutdown behavior should be customizable #8063
Comments
This sounds like a great idea. We've also had commands hardcoded in the main menu that were not easy to override. Perhaps this should be the general pattern? |
I agree. Our app has a workaround for now to remove the item directly from the file menu by command id. I'll save this for 3.0. |
Note that a more invasive hack would be going into the command registry and modifying the command to always be not visible or enabled (maybe you can also directly remove it?). That would disable the command system-wide, rather than just from the menu. |
Looking at the command registry apis, it isn't possible for someone other than the command registerer to affect a registered command. |
Not unless you throw off the hood and use internal details evil grin. I thought we were talking about hacks... |
Description
Currently the app shutdown behavior is provided as a command in the main menu extension. That command cannot easily be overridden by deployments that want to provide a custom shutdown behavior. For example, they may want to close all open notebooks so that there are no zombie kernels are started the next time the user starts a kernel.
The solution is to pull it out into a separate plugin definition and allow it to be overridden, and document it similar to copy sharable link.
The text was updated successfully, but these errors were encountered: