Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples folder to include localization. #8828

Open
goanpeca opened this issue Aug 13, 2020 · 4 comments
Open

Update examples folder to include localization. #8828

goanpeca opened this issue Aug 13, 2020 · 4 comments

Comments

@goanpeca
Copy link
Member

goanpeca commented Aug 13, 2020

Task

After the localization work, the examples folder kept working as expected but the code does not make active use of localization.

In order to promote localizable code, it would be great to be able to showcase the bundled examples following the translation pattern.

Proposed Solution

Update the code in the examples folder to use an actual ITranslator (instead of the nullTranslator that is provided under the hood, and does nothing)

Additional context

Ping me for questions!

@kgoo124
Copy link
Contributor

kgoo124 commented Aug 28, 2020

@goanpeca I would be interested in helping out with this. I've been following the localization efforts since my time as a Cal Poly intern for the past 11 weeks, which makes this a great opportunity to learn how it works. Thank you for taking the lead on this!

@goanpeca
Copy link
Member Author

Hi @kgoo124 thanks for your kind words. That would be great.

I will be making a Localization Call next week for people interested in the workflow and all the moving parts. Also next week Tuesday-Friday I will be exclusively making sure all the localization tools and docs are in place so this is a great time to connect.

Let's have a quick intro meeting, is Monday afternoon ok for you?

Cheers!

@kgoo124
Copy link
Contributor

kgoo124 commented Aug 28, 2020

@goanpeca I can do Monday as long as it's before 5pm PST.

@goanpeca
Copy link
Member Author

Just sent an invite. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants