Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Kernel in busy state is not connected correctly after refreshing the page #9010

Closed
skukhtichev opened this issue Sep 15, 2020 · 3 comments
Assignees
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Backport This PR is slated to be backported after it is merged.
Milestone

Comments

@skukhtichev
Copy link

Description

Notebook Kernel in busy state is not connected correctly after refreshing the page. After reloading the page kernel state is shown is idle and no messages are received in frontend. Interrupting the kernel execution prints error log in Browser's console (Chrome browser):
Screenshot 2020-09-15 at 16 36 19
Reproducible with the latest stable JupyterLab 2.2.8 release

Reproduce

  1. Create a new notebook
  2. Execute the following code:
while True:
    pass
  1. While code is executing refresh the page
  2. After Jupyter notebook is loaded kernel status is shown as idle
  3. create new cell and execute any code
  4. Kernel will be shown as idle and cell's execution status will be switched to running: [*]

Expected behavior

After refreshing JupyterLab Notebook page with busy kernel Kernel should be shown as busy and all messages produced by the kernel should be registered in JupyterLab

Context

  • Operating System and version: MacOS 10.15.6
  • Browser and version: Chrome Version 85.0.4183.102 (Official Build) (64-bit)
  • JupyterLab version: 2.2.4 and 2.2.8
@karlaspuldaro
Copy link
Contributor

Hi @skukhtichev

I was still able to reproduce this in lab v3.0 branch with a related fix by #8432
Upon reload the kernel status circle in the UI is being rendered as idle, but on a mouse over it says Kernel Connecting. Even after a new cell execution is indicated as running [*].

In the classic notebook, the kernel status circle is rendered black, indicating the user it still busy after restart.
I guess we would expect that same behaviour here.
I can take a deeper look into that.

@jasongrout
Copy link
Contributor

After #9172, the kernel indicator indicates the status is unknown when the page is refreshed after executing while True: pass, which correctly reflects what we know (the frontend has not got a status message from the kernel, so it does not know if it is busy or idle or whatever).

Screen Shot 2020-10-17 at 3 33 30 AM

@lresende lresende modified the milestones: 3.0, 2.2.9 Oct 21, 2020
@jasongrout
Copy link
Contributor

Fixed in #9172.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Backport This PR is slated to be backported after it is merged.
Projects
None yet
Development

No branches or pull requests

5 participants