Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the Switch component for the debugger #9354

Closed
jtpio opened this issue Nov 17, 2020 · 1 comment · Fixed by #9432
Closed

Reuse the Switch component for the debugger #9354

jtpio opened this issue Nov 17, 2020 · 1 comment · Fixed by #9432
Labels
pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Nov 17, 2020

When the debugger was added to core there was no default switch component in lab yet: #8010

So it brought its own here:

.jp-Toolbar-item .jp-ToggleSwitch {

Now that ui-components has a Switch, currently used to toggle the single document mode:

image

We should be able to reuse in the debugger extension too:

export class Switch extends Widget {

@jtpio jtpio added this to the Future milestone Nov 17, 2020
@jasongrout jasongrout modified the milestones: Future, 3.0 Nov 17, 2020
@jasongrout
Copy link
Contributor

Adding to 3.0, not as a blocker, but as (I think) an important ux polish issue for 3.0 if we can get to it.

@jasongrout jasongrout modified the milestones: 3.0, 3.1 Dec 2, 2020
@jtpio jtpio modified the milestones: 3.1, 3.0 Dec 10, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants