Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Update CSS for performance enhancements #10127

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Perf: Update CSS for performance enhancements #10127

merged 4 commits into from
Jun 8, 2021

Conversation

goanpeca
Copy link
Member

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@goanpeca goanpeca self-assigned this Apr 21, 2021
@echarles
Copy link
Member

@goanpeca Some issue around long line in codemirror has been reported by @afshin on 2.3 release. Not sure if that issue come from the CSS work, but it could be. Also the CSS changes brings very minor improvement compared to the virtual notebook. Worth triple check that we don't break anything.

@goanpeca goanpeca added this to the 3.1 milestone Apr 21, 2021
@goanpeca
Copy link
Member Author

@goanpeca Some issue around long line in codemirror has been reported by @afshin on 2.3 release. Not sure if that issue come from the CSS work, but it could be. Also the CSS changes brings very minor improvement compared to the virtual notebook. Worth triple check that we don't break anything.

Indeed, looking into those.

@goanpeca
Copy link
Member Author

Before

Screen Shot 2021-05-10 at 10 14 12 PM

Screen Shot 2021-05-10 at 10 14 23 PM

After

Screen Shot 2021-05-10 at 10 08 46 PM

Screen Shot 2021-05-10 at 10 08 53 PM

@goanpeca goanpeca requested a review from blink1073 May 11, 2021 04:17
@blink1073 blink1073 removed their request for review May 26, 2021 12:59
@blink1073 blink1073 removed their assignment May 26, 2021
echarles
echarles approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed code. LGTM. Thx @goanpeca for working on this. I will leave it open a few days before merging cc/ @afshin

@echarles echarles merged commit d3915f6 into jupyterlab:master Jun 8, 2021
This was referenced Jun 9, 2021
Closed
Merged
@fcollonval fcollonval mentioned this pull request Jun 9, 2021
Closed
fcollonval added a commit that referenced this pull request Jun 9, 2021
@fcollonval
Revert visual regression
ebd96ca 
Correct regression introduced in #10127
Fixes #10375
@fcollonval fcollonval mentioned this pull request Jun 9, 2021
Merged
fcollonval added a commit that referenced this pull request Jun 11, 2021
@fcollonval @jtpio
Revert visual regression (#10376)
3a3b401 
* Revert visual regression

Correct regression introduced in #10127
Fixes #10375

* Update reference screenshots

* Generate new reference candidate if UI test failed

* Add missing new references

* Refactor tests

* Fix test

* Fix doc

* Push new reference for tag in toc

* Update docs/source/developer/contributing.rst

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@krassowski krassowski mentioned this pull request Jun 11, 2021
Closed
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@echarles echarles echarles approved these changes

@afshin afshin Awaiting requested review from afshin

Assignees

@afshin afshin

@echarles echarles

@goanpeca goanpeca

Labels
Design System CSS enhancement pkg:apputils pkg:cells pkg:notebook pkg:outputarea status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Performance
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goanpeca @echarles @afshin @blink1073