Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes doc string for toc syncCollapseState setting #10639

Merged

Conversation

andrewfulton9
Copy link
Contributor

References

Previous PR. Docstring update in PR got lost in rebase

Code changes

Changes in toc-extension/schema/plugin.json so syncCollapseState docstring doesn't say the default is true.

User-facing changes

Correct doc strings

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit 3523819 into jupyterlab:master Jul 19, 2021
@fcollonval fcollonval added this to the 3.1 milestone Jul 19, 2021
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 19, 2021
blink1073 pushed a commit that referenced this pull request Jul 19, 2021
#10644)

Co-authored-by: Andrew Fulton <andrewfulton9@gmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement pkg:toc status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants