Normalize translation domain #10728
Merged
Normalize translation domain #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Thanks ! Should we backport this @fcollonval ? |
It may be a good idea to do it. Should it be backported to 3.0.x and 3.1.x? |
I would say yes! |
|
@meeseeksdev please backport to 3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 29, 2021
|
@meeseeksdev please backport to 3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 29, 2021
fcollonval
added a commit
that referenced
this pull request
Aug 4, 2021
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
fcollonval
added a commit
that referenced
this pull request
Aug 4, 2021
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Translation files are normalized. But the domain that reference it in the frontend is not. This breaks the ability to load translation if the domain requested is not normalized.
Code changes
Domain is automatically normalized to be tolerant to extension authors not knowing the correct normalization rule.
User-facing changes
N/A
Backwards-incompatible changes
N/A