Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep cursor at the previous position after cell split #10884

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Aug 22, 2021

References

Fixes #10760

Code changes

Removes the cursor position change introduced in #10297. Also, fixes the docstring.

User-facing changes

Restores the behaviour as in JupyterLab 3.0:

split-3 0

With the current (undesirable behaviour) being:

split-3 1

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 3.1.x milestone Aug 22, 2021
@krassowski krassowski marked this pull request as ready for review August 22, 2021 15:27
@blink1073 blink1073 added the bug label Aug 22, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 8391e92 into jupyterlab:master Aug 22, 2021
@blink1073
Copy link
Member

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 22, 2021
blink1073 pushed a commit that referenced this pull request Aug 23, 2021
…plit (#10888)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: cursor lands in wrong place on cell split
2 participants