Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove status bar item flickering #11065

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 13, 2021

References

Fix #9910
It is part of performance improvement as this reduces the items displacement flagged by Chrome.

Code changes

Set more appropriately isActive on status bar items.

User-facing changes

No more flickering of the status bar items (except from kernel status changes)

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 6402 <- [7283 - 7333 - 7614] -> 8060 3374 <- [3408 - 3450 - 3563] -> 3741
expected 6938 <- [7584 - 7618 - 7760] -> 8204 3461 <- [3524 - 3534 - 3590] -> 4136
switch-from
chromium
actual 410 <- [437 - 456 - 462] -> 514 300 <- [308 - 312 - 330] -> 391
expected 464 <- [480 - 489 - 499] -> 789 310 <- [338 - 344 - 352] -> 370
switch-to
chromium
actual 1671 <- [1698 - 1717 - 1736] -> 1809 1448 <- [1484 - 1501 - 1518] -> 1574
expected 1706 <- [1730 - 1764 - 1814] -> 2015 1541 <- [1549 - 1562 - 1574] -> 1608
close
chromium
actual 5197 <- [5542 - 8901 - 14012] -> 15830 3521 <- [3678 - 3784 - 3958] -> 4237
expected 5176 <- [5770 - 10533 - 14493] -> 18824 3325 <- [3691 - 3890 - 3939] -> 4073

❗ Test metadata have changed
--- /dev/fd/63	2021-09-13 12:27:23.123445996 +0000
+++ /dev/fd/62	2021-09-13 12:27:23.123445996 +0000
@@ -34,7 +34,7 @@
       "voltage": ""
     },
     "mem": {
-      "total": 7291699200
+      "total": 7291695104
     },
     "osInfo": {
       "arch": "x64",
@@ -46,7 +46,7 @@
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
+      "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
       "servicepack": "",
       "uefi": false
     }

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit d103ccc into jupyterlab:master Sep 13, 2021
@blink1073
Copy link
Member

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Sep 13, 2021
blink1073 pushed a commit that referenced this pull request Sep 13, 2021
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@blink1073 blink1073 added the bug label Sep 16, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:docmanager pkg:logconsole pkg:statusbar status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log console statusbar icon classes are applied with a delay causing flickering
2 participants