-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove status bar item flickering #11065
Remove status bar item flickering #11065
Conversation
Thanks for making a pull request to jupyterlab! |
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2021-09-13 12:27:23.123445996 +0000
+++ /dev/fd/62 2021-09-13 12:27:23.123445996 +0000
@@ -34,7 +34,7 @@
"voltage": ""
},
"mem": {
- "total": 7291699200
+ "total": 7291695104
},
"osInfo": {
"arch": "x64",
@@ -46,7 +46,7 @@
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "cfc067bfcb844f35865e279a1b0e66c5",
+ "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
"servicepack": "",
"uefi": false
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@meeseeksdev please backport to 3.1.x |
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
References
Fix #9910
It is part of performance improvement as this reduces the items displacement flagged by Chrome.
Code changes
Set more appropriately
isActive
on status bar items.User-facing changes
No more flickering of the status bar items (except from kernel status changes)
Backwards-incompatible changes
N/A