Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @types/webpack-env from ui-components #11587

Merged
merged 1 commit into from Dec 2, 2021
Merged

Remove @types/webpack-env from ui-components #11587

merged 1 commit into from Dec 2, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 30, 2021 •
edited

References

Fixes #11567

Opening this PR to check whether webpack-env is still needed in the ui-components package.

Code changes

Dependencies

User-facing changes

Backwards-incompatible changes

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio mentioned this pull request Nov 30, 2021
Closed
@jtpio
Copy link
Member Author

jtpio commented Nov 30, 2021

CI and UI tests are passing, so marking as ready.

cc @telamonian in case you have some input, since this was originally added in 9c7bda9

@jtpio jtpio marked this pull request as ready for review November 30, 2021 14:33
@jtpio jtpio added this to the 4.0 milestone Nov 30, 2021
fcollonval
fcollonval approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit 7ceeb6f into jupyterlab:master Dec 2, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
maintenance pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

[PATCH] Obsolete dep on webpack-env in packages/ui-components ?
2 participants
@jtpio @fcollonval