New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ILayoutRestorer
optional in the extension tutorial
#11677
Conversation
Thanks for making a pull request to jupyterlab! |
A follow-up to this would be to update the apod repo to take these changes into account: https://github.com/jupyterlab/jupyterlab_apod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio
I caught a typo. Otherwise LGTM
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
I think we should wait to solve jupyterlab/jupyterlab_apod#10 before backporting it to 3.2.x |
References
Fixes #11611.
The motivation here is to make extension authors more aware of the
optional
field of the plugin definition, so they can build extensions that can be used in more JupyterLab based applications by default.Code changes
Documentation changes.
ILayoutRestorer
anoptional
to coveroptional
in the extension tutorialICommandPaletter
asrequires
to also cover tokens specified asrequires
.User-facing changes
None for end users.
Documentation changes can be previewed on RTD: https://jupyterlab--11677.org.readthedocs.build/en/11677/extension/extension_tutorial.html
Backwards-incompatible changes
None