Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix run cells breaking on non-header markdown cells #12027

Merged
merged 1 commit into from Apr 14, 2022

Conversation

andrewfulton9
Copy link
Contributor

References

Fixes #12026
If this could be backported to 3.3.x, that would be great too.

Code changes

in the toc-extension runCells command, the logic of when to break out of a loop running each code cell is amended so that the loop is not broken if MarkdownCell.headingInfo.level is equal to -1 (markdown cell is not a header)

User-facing changes

Now code cells under a ToC section are run after runCells is called even if they are under a non-header markdown cell

chrome-capture (5)

Backwards-incompatible changes

None that I am aware

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added the bug label Feb 8, 2022
@krassowski krassowski added this to the 3.3.x milestone Feb 8, 2022
@krassowski
Copy link
Member

Worth adding a test case?

@fcollonval
Copy link
Member

@andrewfulton9 you can add it in galata/test/jupyterlab/toc-running.test.ts as it test that feature. You should be able to test it by changing the generated notebook (see beforeEach). And to test cell output content, you could look at the test Check cell output # in galata/test/jupyterlab/notebook-run.test.ts

@andrewfulton9
Copy link
Contributor Author

@fcollonval, thanks for the extra context for updating the test. I'll try to get that added today.

@fcollonval fcollonval merged commit 95312de into jupyterlab:master Apr 14, 2022
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 14, 2022
fcollonval pushed a commit that referenced this pull request Apr 14, 2022
…ls (#12405)

Co-authored-by: Andrew Fulton <andrewfulton9@gmail.com>
gabalafou pushed a commit to gabalafou/jupyterlab that referenced this pull request Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToC Run Cells doesn't run nested cells after non-header markdown cells
3 participants