fix run cells breaking on non-header markdown cells #12027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #12026
If this could be backported to 3.3.x, that would be great too.
Code changes
in the toc-extension
runCells
command, the logic of when to break out of a loop running each code cell is amended so that the loop is not broken ifMarkdownCell.headingInfo.level
is equal to -1 (markdown cell is not a header)User-facing changes
Now code cells under a ToC section are run after runCells is called even if they are under a non-header markdown cell
Backwards-incompatible changes
None that I am aware