Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation UI test for extension manager search #12552

Merged
merged 1 commit into from May 10, 2022

Conversation

fcollonval
Copy link
Member

References

Fix UI documentation as again the npm popularity for searched extension changed... .

Code changes

N/A

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

please update documentation snapshots

@fcollonval fcollonval changed the title Update comment Fix documentation UI test for extension manager search May 9, 2022
@fcollonval fcollonval marked this pull request as ready for review May 10, 2022 07:28
@jtpio
Copy link
Member

jtpio commented May 10, 2022

Linking to #12340 for reference.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 2de6163 into master May 10, 2022
@jtpio jtpio deleted the fcollonval-patch-2 branch May 10, 2022 08:23
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 19045 <- [19469 - 19643 - 19801] -> 20536 4678 <- [4848 - 4932 - 5010] -> 5690
expected 18736 <- [19223 - 19441 - 19605] -> 20389 4665 <- [4848 - 4893 - 4964] -> 5630
Mean relative change 1.2% ± 0.4% 0.4% ± 1.0%
switch-from
chromium
actual 867 <- [916 - 940 - 1007] -> 1186 706 <- [736 - 755 - 771] -> 958
expected 842 <- [904 - 923 - 950] -> 1238 698 <- [734 - 751 - 773] -> 1002
Mean relative change 2.5% ± 2.4% -0.7% ± 2.1%
switch-to
chromium
actual 503 <- [596 - 655 - 679] -> 804 1145 <- [1219 - 1244 - 1274] -> 1613
expected 497 <- [589 - 647 - 671] -> 749 1171 <- [1219 - 1246 - 1272] -> 1643
Mean relative change 1.6% ± 2.5% -0.4% ± 2.4%
close
chromium
actual 1533 <- [1607 - 1625 - 1649] -> 1817 795 <- [844 - 860 - 878] -> 1035
expected 1547 <- [1589 - 1607 - 1630] -> 1826 786 <- [837 - 851 - 874] -> 1021
Mean relative change 1.0% ± 0.9% 0.8% ± 1.5%

Changes are computed with expected as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants