stub extension search in UI test #12714
Conversation
|
Thanks for making a pull request to jupyterlab! |
| @@ -81,6 +86,8 @@ test.describe('Extension Manager', () => { | |||
| expect( | |||
| await page.screenshot({ clip: { y: 31, x: 0, width: 283, height: 600 } }) | |||
| ).toMatchSnapshot('extensions_search.png'); | |||
|
|
|||
| await unstubExtensionsSearch(page); | |||
There was a problem hiding this comment.
Yeah, it turns out page.route doesn't remove the route stub after a test completes, so it's required to call page.unroute manually after each test. If anybody knows an alternative to this (that doesn't make it so easy for devs to accidentally share stubs across tests), please LMK!
There was a problem hiding this comment.
@dlqqq how did you come to that conclusion? The .route is linked to the page object that is unique for each test (except when using some specific describe block). So I'm a bit surprised it needs to be undone explicitly.
There was a problem hiding this comment.
I noticed this when adding page.route caused the other snapshot tests to fail. I'm also surprised, since I also assumed that the page object is unique per test. This probably warrants further investigation since ideally page routings shouldn't get shared across tests.
|
Thanks a lot for working on this @dlqqq |
References
Fixes #12340. Lays groundwork for further stubbing (if necessary) in the extension manager UI tests.
Code changes
Adds stub for extension search. To stub the GH avatars in the search results, I decided to use the Jupyter logo since the avatars in the original snapshot were those of QuantStack and another GitHub user (deathbeds@). Wanted to avoid copyright/trademark/legal/privacy issues.
Open to feedback regarding the stub data I've used. Now is the time to change it if we want to.
User-facing changes
None.
Backwards-incompatible changes
None known.