Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Lumino 2 #12992

Merged
merged 33 commits into from Sep 4, 2022
Merged

Update to Lumino 2 #12992

merged 33 commits into from Sep 4, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 23, 2022

This PR migrates the JupyterLab 4 code base to use Lumino 2.

References

Fixes #12982

Code changes

User-facing changes

Backwards-incompatible changes

@afshin afshin added maintenance api-change A change that should be accompanied by a major version increase dependencies Pull requests that update a dependency file labels Aug 23, 2022
@afshin afshin added this to the 4.0.0 milestone Aug 23, 2022
@afshin afshin self-assigned this Aug 23, 2022
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

afshin
afshin commented Sep 3, 2022
View reviewed changes
Copy link
Member Author

@afshin afshin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update snapshots

@blink1073
Copy link
Member

please update snapshots

@blink1073 blink1073 merged commit 5ea1bc7 into jupyterlab:master Sep 4, 2022
@blink1073 blink1073 deleted the lumino-2 branch September 4, 2022 13:30
@blink1073
Copy link
Member

Thanks @afshin!

@jtpio jtpio mentioned this pull request Sep 5, 2022
Closed
@isabela-pf isabela-pf mentioned this pull request Nov 15, 2022
Closed
hbcarlos pushed a commit to hbcarlos/jupyterlab that referenced this pull request Jan 29, 2023
@afshin @fcollonval @github-actions
Update to Lumino 2 (jupyterlab#12992)
88c3650 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hbcarlos pushed a commit to hbcarlos/jupyterlab that referenced this pull request Jan 29, 2023
@afshin @fcollonval @github-actions
Update to Lumino 2 (jupyterlab#12992)
302f2da 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hbcarlos pushed a commit to hbcarlos/jupyterlab that referenced this pull request Jan 29, 2023
@afshin @fcollonval @github-actions
Update to Lumino 2 (jupyterlab#12992)
a53f72c 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels
api-change A change that should be accompanied by a major version increase dependencies Pull requests that update a dependency file documentation maintenance pkg:application pkg:apputils pkg:attachments pkg:cell-toolbar pkg:cells pkg:celltags pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:csvviewer pkg:debugger pkg:docmanager pkg:docprovider pkg:docregistry pkg:documentsearch pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:htmlviewer pkg:imageviewer pkg:inspector pkg:json pkg:launcher pkg:logconsole pkg:lsp pkg:mainmenu pkg:markdownviewer pkg:mathjax2 pkg:notebook pkg:observables pkg:outputarea pkg:pdf pkg:property-inspector pkg:rendermime pkg:running pkg:services pkg:settingeditor pkg:settingregistry pkg:shared-models pkg:shortcuts pkg:statedb pkg:statusbar pkg:terminal pkg:toc pkg:tooltip pkg:translation pkg:ui-components pkg:vega tag:Examples tag:Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Update JupyterLab 4 to Lumino 2
3 participants
@afshin @fcollonval @blink1073