Raise ceiling on jupyter_server dependency to < 3 #13068

Zsailer · 2022-09-08T17:39:47Z

References

Discuss in today's Jupyter Server meeting.

Also see jupyterlab/jupyterlab_server#302. While it's not strictly necessary to merge+release that PR, first, this PR isn't useful until jupyterlab_server relaxes its pin.

Code changes

This raises the ceiling on JupyterLab's jupyter_server dependency.

This is a temporary change. I think we want JupyterLab 4.0 to depend on Jupyter Server 2.0, i.e. jupyter_server~=2.0 once Jupyter Server 2.0 reaches final release. JupyterLab 4.0 won't work with Jupyter Server 1.0 (since RTC will likely rely on Jupyter Server 2.0 features).

This change should also be backported to a JLab 3.5 branch/release, but we'll keep this change as-is going forward—users can always use either JS 1.x and 2.x in JLab >= 3.5

User-facing changes

This enables folks to test Jupyter Server 2.0 with JupyterLab 4.0.

Backwards-incompatible changes

None.

cc @fcollonval

jupyterlab-probot · 2022-09-08T17:39:49Z

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

Zsailer · 2022-09-09T14:54:11Z

@fcollonval, woah sorry I checked in the setup.cfg! Apparently I was using an old copy of jupyterlab 😆

fcollonval

Thanks @Zsailer for both PRs

woah sorry I checked in the setup.cfg! Apparently I was using an old copy of jupyterlab laughing

Don't worry about it

Zsailer · 2022-09-09T15:05:42Z

We also needed to relax the dependency in notebook_shim: jupyter/notebook_shim#12

I'll cut a release in the next hour or so.

github-actions · 2022-09-09T17:09:48Z

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
`chromium`
actual	2811 <- [2871 - 2897 - 2933] -> 3062	4017 <- [4112 - 4146 - 4201] -> 4555
expected	2820 <- [2896 - 2940 - 2985] -> 3254	4056 <- [4235 - 4292 - 4352] -> 4542
Mean relative change	-1.5% ± 0.6%	-3.2% ± 0.6%
switch-from
`chromium`
actual	506 <- [543 - 561 - 581] -> 708	547 <- [584 - 642 - 665] -> 709
expected	523 <- [557 - 575 - 597] -> 674	538 <- [601 - 664 - 692] -> 750
Mean relative change	-2.2% ± 1.8%	-3.4% ± 2.1%
switch-to
`chromium`
actual	214 <- [233 - 246 - 274] -> 360	638 <- [662 - 678 - 699] -> 796
expected	220 <- [240 - 250 - 263] -> 407	655 <- [673 - 690 - 710] -> 835
Mean relative change	0.7% ± 4.3%	-1.2% ± 1.3%
close
`chromium`
actual	452 <- [479 - 489 - 502] -> 539	617 <- [751 - 766 - 778] -> 811
expected	461 <- [481 - 494 - 509] -> 616	625 <- [764 - 779 - 794] -> 859
Mean relative change	-1.1% ± 1.1%	-1.9% ± 1.1%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha /home/runner/work/_actions/jupyterlab/benchmarks/v1.2/memory-leaks
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell

Memory change: -243 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
CodeCellModel	1	+110 B
ContentString	1	+698 B
Detached DOMStringMap	1	+44 B
DisposableSet	1	+179 B
ModelDB	1	+922 B
ObservableList	1	+110 B
ObservableString	1	+47 B
OutputAreaModel	1	+107 B
Promise	1	+16 B
TypeError	1	+526 B
UndoManager	1	+1.38 kB
YArray	1	+207 B
YCodeCell	1	+96 B
YMap	1	+273 B
YText	1	+314 B
Detached HTMLCollection	2	+220 B
ObservableJSON	2	+667 B
StackItem	2	+952 B
StyleModule	2	+652 B
ContentType	3	+268 B
Set	3	+8.38 kB
DeleteItem	4	+80 B
DeleteSet	4	+720 B
Detached Attr	4	+384 B
Detached DOMTokenList	4	+252 B
Detached HTMLDivElement	4	+27.5 kB
ObservableValue	4	+112 B
ContentAny	5	+248 B
EventHandler	6	+205 B
ID	9	+288 B
Item	9	+1.94 kB
DOMRectReadOnly	12	+672 B
Map	12	+3.31 kB
Signal	15	+240 B
Detached EventListener	129	+18.1 kB
Detached V8EventListener	129	+12.9 kB
Detached InternalNode	151	+18.9 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/notebook/src/model.ts:406:30 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/model.ts:405:25 invokeSlot http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19811:18 Object.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19769:17 Signal.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19453:17 webpack://jupyterlab/packages/notebook/src/celllist.ts:555:18
Array	+2	[StyleModule, ...]	webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0 webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6399:8 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6087:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1207:17 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42 webpack://jupyterlab/packages/cells/src/inputarea.ts:63:35
Array	+2	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/completer/src/handler.ts:83:31 webpack://jupyterlab/packages/completer/src/manager.ts:134:22 webpack://jupyterlab/packages/notebook-extension/src/index.ts:1786:25
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5
Array	+9	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6622:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7
Map	+1	Map(b9c711e2-13d7-4be5-8868-c09504395122: CodeCellModel, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/notebook/src/celllist.ts:290:18 webpack://jupyterlab/packages/notebook/src/actions.tsx:415:16 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3945:0 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3994:0
Map	+7	Map(cellOrder: ObservableUndoableList, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:422:9 webpack://jupyterlab/packages/codeeditor/src/editor.ts:243:33 webpack://jupyterlab/packages/cells/src/model.ts:180:4 webpack://jupyterlab/packages/cells/src/model.ts:634:4 webpack://jupyterlab/packages/notebook/src/model.ts:711:13
Set	+1	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4994:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+1	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4995:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+1	Set(ModelDB, ...)	DisposableSet.add http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:16309:21 webpack://jupyterlab/packages/observables/src/modeldb.ts:518:22 webpack://jupyterlab/packages/notebook/src/model.ts:709:39 webpack://jupyterlab/packages/notebook/src/model.ts:682:22 webpack://jupyterlab/packages/notebook/src/actions.tsx:410:38 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19

Create a markdown cell

Memory change: -195 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ActivityMonitor	1	+38 B
ArraySearchMarker	1	+5 B
AttachmentsModel	1	+-13 B
AttachmentsResolver	1	+14 B
CodeCellModel	1	+82 B
ContentString	1	+700 B
Debouncer	1	+1.47 kB
Detached HTMLAnchorElement	1	+384 B
Detached HTMLButtonElement	1	+2.78 kB
Detached HTMLHeadingElement	1	+1.36 kB
Detached V8EventHandlerNonNull	1	+2.44 kB
Error	1	+1.1 kB
MarkdownCell	1	+2.28 kB
MarkdownCellModel	1	+22 B
ObservableList	1	+110 B
ObservableMap	1	+1.28 kB
OutputAreaModel	1	+107 B
Poll	1	+1.67 kB
RenderMimeRegistry	1	+246 B
RenderedMarkdown	1	+66 B
TypeError	1	+526 B
YArray	1	+207 B
YCodeCell	1	+96 B
YMarkdownCell	1	+14 B
Detached CSSStyleDeclaration	2	+108 B
Detached HTMLElement	2	+464 B
DisposableSet	2	+338 B
ModelDB	2	+1.56 kB
ObservableString	2	+66 B
PromiseDelegate	2	+1.32 kB
StackItem	2	+932 B
UndoManager	2	+1.78 kB
YMap	2	+477 B
YText	2	+534 B
DeleteItem	3	+60 B
Detached DOMStringMap	3	+104 B
DeleteSet	4	+700 B
ObservableJSON	4	+905 B
Promise	4	+1.14 kB
ContentType	5	+300 B
Set	5	+8.58 kB
StyleModule	5	+738 B
ContentAny	7	+364 B
Detached Text	7	+756 B
ObservableValue	8	+252 B
Detached HTMLDivElement	10	+34.6 kB
EventHandler	10	+333 B
Detached DOMTokenList	13	+852 B
ID	13	+416 B
Item	13	+2.44 kB
Detached HTMLCollection	17	+2.08 kB
DOMRectReadOnly	18	+1.01 kB
Map	18	+4.76 kB
Signal	39	+624 B
Detached V8EventListener	129	+12.9 kB
Detached EventListener	130	+20.5 kB
Detached InternalNode	165	+23.6 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[48fd8f24-8216-412c-81cf-14b177500493, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2483:27 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2478:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:356:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2274:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:4109:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:4049:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:2913:23
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5
Array	+2	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/notebook/src/model.ts:406:30 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/model.ts:405:25 invokeSlot http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19811:18 Object.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19769:17 Signal.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19453:17 webpack://jupyterlab/packages/notebook/src/celllist.ts:555:18
Array	+4	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/completer/src/handler.ts:83:31 webpack://jupyterlab/packages/completer/src/manager.ts:134:22 webpack://jupyterlab/packages/notebook-extension/src/index.ts:1786:25
Array	+5	[StyleModule, ...]	webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0 webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6399:8 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6087:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1207:17 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42 webpack://jupyterlab/packages/cells/src/inputarea.ts:63:35
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6622:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7
Map	+2	Map(8fbfb08a-d666-4340-9d91-01f42a667a6c: CodeCellModel, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/notebook/src/celllist.ts:290:18 webpack://jupyterlab/packages/notebook/src/actions.tsx:415:16 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3945:0 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3994:0
Map	+14	Map(cellOrder: ObservableUndoableList, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:422:9 webpack://jupyterlab/packages/codeeditor/src/editor.ts:243:33 webpack://jupyterlab/packages/cells/src/model.ts:180:4 webpack://jupyterlab/packages/cells/src/model.ts:634:4 webpack://jupyterlab/packages/notebook/src/model.ts:711:13
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4994:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4995:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+2	Set(ModelDB, ...)	DisposableSet.add http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:16309:21 webpack://jupyterlab/packages/observables/src/modeldb.ts:518:22 webpack://jupyterlab/packages/notebook/src/model.ts:709:39 webpack://jupyterlab/packages/notebook/src/model.ts:682:22 webpack://jupyterlab/packages/notebook/src/actions.tsx:410:38 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19

Create a raw cell

Memory change: -152 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
AttachmentsModel	1	+-13 B
CodeCellModel	1	+82 B
ContentString	1	+698 B
Detached CSSStyleDeclaration	1	+48 B
ObservableList	1	+110 B
ObservableMap	1	+1.28 kB
OutputAreaModel	1	+107 B
RawCellModel	1	+22 B
YArray	1	+207 B
YCodeCell	1	+96 B
YRawCell	1	+14 B
Detached DOMStringMap	2	+68 B
DisposableSet	2	+338 B
ModelDB	2	+1.56 kB
ObservableString	2	+66 B
Promise	2	+62 B
StackItem	2	+932 B
UndoManager	2	+1.73 kB
YMap	2	+477 B
YText	2	+534 B
DeleteItem	3	+60 B
DeleteSet	4	+700 B
ObservableJSON	4	+905 B
StyleModule	4	+716 B
ContentType	5	+300 B
Detached HTMLCollection	5	+544 B
Set	5	+8.57 kB
ContentAny	7	+364 B
ObservableValue	8	+252 B
Detached DOMTokenList	9	+588 B
Detached HTMLDivElement	9	+28.5 kB
EventHandler	10	+333 B
ID	13	+416 B
Item	13	+2.44 kB
DOMRectReadOnly	16	+896 B
Map	18	+4.71 kB
Signal	30	+480 B
TypeError	47	+91.3 kB
Object	69	+194 kB
Detached EventListener	129	+18.1 kB
Detached V8EventListener	129	+12.9 kB
Detached InternalNode	154	+19.3 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[c5333080-87f6-4f2a-b448-0853e96e1b1f, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2483:27 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2478:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:356:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2274:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:4109:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:4049:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:2913:23
Array	+2	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/notebook/src/model.ts:406:30 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/model.ts:405:25 invokeSlot http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19811:18 Object.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19769:17 Signal.emit http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19453:17 webpack://jupyterlab/packages/notebook/src/celllist.ts:555:18
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5
Array	+4	[StyleModule, ...]	webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0 webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6399:8 webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6087:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1207:17 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42 webpack://jupyterlab/packages/cells/src/inputarea.ts:63:35
Array	+4	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19602:17 Signal.connect http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24 webpack://jupyterlab/packages/completer/src/handler.ts:83:31 webpack://jupyterlab/packages/completer/src/manager.ts:134:22 webpack://jupyterlab/packages/notebook-extension/src/index.ts:1786:25
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6622:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7
Map	+2	Map(04896dca-22bd-4b41-9916-9dc61106dbd3: CodeCellModel, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/notebook/src/celllist.ts:290:18 webpack://jupyterlab/packages/notebook/src/actions.tsx:415:16 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3945:0 webpack://jupyterlab/node_modules/react-dom/cjs/react-dom.development.js:3994:0
Map	+14	Map(cellOrder: ObservableUndoableList, ...)	webpack://jupyterlab/packages/observables/src/observablemap.ts:210:14 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:532:13 webpack://jupyterlab/packages/observables/src/modeldb.ts:422:9 webpack://jupyterlab/packages/codeeditor/src/editor.ts:243:33 webpack://jupyterlab/packages/cells/src/model.ts:180:4 webpack://jupyterlab/packages/cells/src/model.ts:634:4 webpack://jupyterlab/packages/notebook/src/model.ts:711:13
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4994:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:2131:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4995:14 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0 webpack://jupyterlab/packages/codemirror/src/editor.ts:1200:16 webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set	+2	Set(ModelDB, ...)	DisposableSet.add http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:16309:21 webpack://jupyterlab/packages/observables/src/modeldb.ts:518:22 webpack://jupyterlab/packages/notebook/src/model.ts:709:39 webpack://jupyterlab/packages/notebook/src/model.ts:682:22 webpack://jupyterlab/packages/notebook/src/actions.tsx:410:38 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2342:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:3951:33 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:1080:20 webpack://jupyterlab/packages/ui-components/src/components/toolbar.tsx:637:19

✔ Adding a cell (303281ms)

Move a code cell

Memory change: -408 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ContentString	2	+32 B
StackItem	2	+1.14 kB
YArray	2	+440 B
YMap	2	+533 B
YText	2	+325 B
DeleteItem	4	+80 B
DeleteSet	4	+904 B
ContentType	6	+536 B
ContentAny	8	+408 B
DOMRectReadOnly	8	+448 B
EventHandler	12	+386 B
Map	12	+2.13 kB
ID	16	+512 B
Item	16	+2.32 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5

Array

+16

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6592:12
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7

Move a markdown cell

Memory change: -409 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ContentString	2	+32 B
StackItem	2	+1.14 kB
YMap	2	+421 B
YText	2	+440 B
ContentType	4	+64 B
DeleteItem	4	+80 B
DeleteSet	4	+904 B
ContentAny	6	+320 B
EventHandler	8	+269 B
DOMRectReadOnly	10	+560 B
Map	10	+1.8 kB
ID	12	+384 B
Item	12	+1.41 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5

Array

+12

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6592:12
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7

Move a raw cell

Memory change: -349 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ContentString	2	+32 B
StackItem	2	+1.14 kB
YMap	2	+421 B
YText	2	+440 B
ContentType	4	+64 B
DeleteItem	4	+80 B
DeleteSet	4	+904 B
ContentAny	6	+320 B
EventHandler	8	+269 B
Map	10	+1.82 kB
DOMRectReadOnly	12	+672 B
ID	12	+384 B
Item	12	+1.41 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5

Array

+12

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4217:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:11005:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6562:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6535:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6592:12
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6941:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4746:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:6940:7

✔ Drag and drop a cell (293345ms)

File editor memory leaks

Create a file

Memory change: -101 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+2.95 kB
Set	1	+8.08 kB
TypeError	1	+1.47 kB
VirtualElementPass	1	+52 B
Detached ElementIntersectionObserverData	2	+128 B
Detached HTMLButtonElement	2	+30.5 kB
Detached SVGCircleElement	2	+1.49 kB
LabIcon	2	+1.07 kB
Detached CSSStyleDeclaration	3	+196 B
Detached HTMLLIElement	3	+6.38 kB
Detached NodeList	3	+168 B
VirtualText	3	+106 B
Detached SVGGElement	4	+3.9 kB
NavigationHistoryEntry	4	+960 B
StyleModule	4	+716 B
VirtualElement	4	+2.1 kB
Detached HTMLSpanElement	5	+3.18 kB
Detached SVGAnimatedPreserveAspectRatio	5	+440 B
Detached SVGAnimatedRect	5	+440 B
Detached SVGPathElement	5	+2.33 kB
Detached SVGSVGElement	5	+10.6 kB
Detached SVGAnimatedNumber	7	+560 B
Detached Text	9	+944 B
Detached Attr	10	+960 B
Detached DOMTokenList	13	+848 B
Detached HTMLDivElement	15	+42.5 kB
Detached SVGAnimatedString	16	+1.15 kB
Detached SVGAnimatedTransformList	16	+1.41 kB
Detached HTMLCollection	17	+2.14 kB
Detached SVGAnimatedLength	26	+2.29 kB
Detached EventListener	129	+18.1 kB
Detached V8EventListener	129	+12.9 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+4

[StyleModule, ...]

  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6399:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6087:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:1207:17         
  webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:73:11          
  webpack://jupyterlab/packages/fileeditor/src/widget.ts:219:13          
  webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42

✔ Opening a text file (91621ms)

Notebook memory leaks

Create a notebook

Memory change: -12.7 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+3.02 kB
Set	1	+7.92 kB
Settings	1	+44 B
Signal	1	+16 B
TypeError	1	+2 kB
VirtualElementPass	1	+52 B
Detached ElementIntersectionObserverData	2	+128 B
Detached HTMLButtonElement	2	+30.8 kB
Detached SVGCircleElement	2	+1.49 kB
HTMLDivElement	2	+382 B
LabIcon	2	+-75 B
StyleModule	2	+652 B
Detached CSSStyleDeclaration	3	+220 B
Detached HTMLLIElement	3	+7.42 kB
Detached NodeList	3	+168 B
StackItem	3	+2.26 kB
VirtualText	3	+118 B
YRange	3	+612 B
NavigationHistoryEntry	4	+960 B
VirtualElement	4	+-280 B
Detached HTMLSpanElement	5	+4.15 kB
Detached SVGAnimatedPreserveAspectRatio	5	+440 B
Detached SVGAnimatedRect	5	+440 B
Detached SVGSVGElement	5	+12.2 kB
DeleteItem	6	+120 B
DeleteSet	6	+1.3 kB
Detached SVGGElement	6	+6.49 kB
RelativePosition	6	+552 B
Detached SVGPathElement	7	+3.26 kB
Detached SVGAnimatedNumber	9	+720 B
Detached Text	9	+980 B
Detached Attr	10	+960 B
ID	12	+384 B
Detached DOMTokenList	14	+1.08 kB
Detached HTMLDivElement	15	+43.5 kB
Detached HTMLCollection	17	+2.28 kB
Detached SVGAnimatedString	20	+1.44 kB
Detached SVGAnimatedTransformList	20	+1.76 kB
Detached SVGAnimatedLength	26	+2.29 kB
Detached EventListener	129	+18.1 kB
Detached V8EventListener	129	+12.9 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+1

[{signal, slot, thisArg}, ...]

Object.connect  http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19601:19
Signal.connect  http://localhost:8888/static/lab/jlab_core.fd685462a959861c7cf3.js:19427:24
                webpack://jupyterlab/packages/settingregistry/src/settingregistry.ts:672:32
                webpack://jupyterlab/packages/settingregistry/src/settingregistry.ts:336:13

Array

+2

[StyleModule, ...]

  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6399:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6087:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:1207:17         
  webpack://jupyterlab/packages/codemirror/src/editor.ts:241:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42           
  webpack://jupyterlab/packages/cells/src/inputarea.ts:63:35

Array

+3

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4975:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4643:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4645:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:4757:7 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.0bb9cc0ca3c96dd5c827.js:1972:5

✔ Opening a notebook (95032ms)

4 passing (13m)

Zsailer · 2022-09-12T21:18:25Z

This change should also be backported to a JLab 3.5 branch/release, but we'll keep this change as-is going forward—users can always use either JS 1.x and 2.x in JLab >= 3.5

@fcollonval Do you want to create 3.5.x branch now? I can backport this to PR to that branch.

fcollonval · 2022-09-13T07:27:06Z

@Zsailer thanks for proposing - I would like to wait for the list of PRs to be frozen before doing so (Sept 21st). That leaves us the ability to do patch release on 3.4.x without increasing maintenance load by backporting things twice.

fcollonval · 2022-10-04T14:49:35Z

@meeseeksdev please backport to 3.5.x

lumberbot-app · 2022-10-04T14:49:56Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout 3.5.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 1a07f39bb530a29f897d9127a514630bf52cc914

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #13068: Raise ceiling on jupyter_server dependency to < 3'

Push to a named branch:

git push YOURFORK 3.5.x:auto-backport-of-pr-13068-on-3.5.x

Create a PR against branch 3.5.x, I would have named this PR:

"Backport PR #13068 on branch 3.5.x (Raise ceiling on jupyter_server dependency to < 3)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

…ncy to < 3

…#13178) Co-authored-by: Zachary Sailer <zsailer@apple.com>

bump jupyter_server pin one major version (<3)

fc1ce0f

Zsailer added the enhancement label Sep 8, 2022

github-actions bot assigned Zsailer Sep 8, 2022

github-actions bot and others added 2 commits September 8, 2022 17:41

Automatic application of license header

bfde50e

Remove setup.cfg

a6c6672

fcollonval added this to the 4.0.0 milestone Sep 9, 2022

fcollonval mentioned this pull request Sep 9, 2022

JupyterLab 3.5.0 Release #13064

Closed

8 tasks

fcollonval approved these changes Sep 9, 2022

View reviewed changes

fcollonval merged commit 1a07f39 into jupyterlab:master Sep 9, 2022

Zsailer mentioned this pull request Sep 22, 2022

Meeting Notes 2022 jupyter-server/team-compass#15

Closed

lumberbot-app bot added the Still Needs Manual Backport label Oct 4, 2022

fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Oct 4, 2022

Backport PR jupyterlab#13068: Raise ceiling on jupyter_server depende…

bff6792

…ncy to < 3

fcollonval mentioned this pull request Oct 4, 2022

Backport PR #13068 on branch 3.5.x (Raise ceiling on jupyter_server dependency to < 3) #13178

Merged

fcollonval added a commit that referenced this pull request Oct 5, 2022

Backport PR #13068: Raise ceiling on jupyter_server dependency to < 3 (…

aef82db

…#13178) Co-authored-by: Zachary Sailer <zsailer@apple.com>

fcollonval removed the Still Needs Manual Backport label Oct 5, 2022

github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise ceiling on jupyter_server dependency to < 3 #13068

Raise ceiling on jupyter_server dependency to < 3 #13068

Zsailer commented Sep 8, 2022 •

edited

jupyterlab-probot bot commented Sep 8, 2022

Zsailer commented Sep 9, 2022

fcollonval left a comment

Zsailer commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

Zsailer commented Sep 12, 2022

fcollonval commented Sep 13, 2022

fcollonval commented Oct 4, 2022

lumberbot-app bot commented Oct 4, 2022

Raise ceiling on jupyter_server dependency to < 3 #13068

Raise ceiling on jupyter_server dependency to < 3 #13068

Conversation

Zsailer commented Sep 8, 2022 • edited

References

Code changes

User-facing changes

Backwards-incompatible changes

jupyterlab-probot bot commented Sep 8, 2022

Zsailer commented Sep 9, 2022

fcollonval left a comment

Choose a reason for hiding this comment

Zsailer commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

Benchmark report

Cell memory leaks

File editor memory leaks

Notebook memory leaks

Zsailer commented Sep 12, 2022

fcollonval commented Sep 13, 2022

fcollonval commented Oct 4, 2022

lumberbot-app bot commented Oct 4, 2022

Zsailer commented Sep 8, 2022 •

edited