Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove width: 100% of jp-WindowedPanel-window #13154

Merged
merged 1 commit into from Sep 30, 2022
Merged

Remove width: 100% of jp-WindowedPanel-window #13154

merged 1 commit into from Sep 30, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 29, 2022

References

Noticed while iterating on the JupyterLab update for Notebook 7 in jupyter/notebook#6539.

This extra width: 100% causes some layout issues in Notebook 7 and does not seem necessary in JupyterLab.

Code changes

Update CSS for jp-WindowedPanel-window.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0.0 milestone Sep 29, 2022
@github-actions github-actions bot added Design System CSS pkg:ui-components tag:CSS For general CSS related issues and pecadilloes labels Sep 29, 2022
fcollonval
fcollonval approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

@fcollonval fcollonval merged commit 6a284ba into jupyterlab:master Sep 30, 2022
@jtpio jtpio deleted the remove-windowed-panel-width branch September 30, 2022 08:51
@jtpio jtpio mentioned this pull request Sep 30, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
Design System CSS maintenance pkg:ui-components tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @fcollonval