Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try the GitHub Playwright reporter on CI #13198

Merged
merged 1 commit into from Oct 6, 2022
Merged

Try the GitHub Playwright reporter on CI #13198

merged 1 commit into from Oct 6, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 6, 2022

References

Try using the GitHub Playwright reporter on CI, so it can add annotations to the GitHub UI directly:

https://playwright.dev/docs/test-reporters#github-actions-annotations

Code changes

Playwright config update.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0.0 milestone Oct 6, 2022
@jtpio jtpio marked this pull request as ready for review October 6, 2022 15:03
fcollonval
fcollonval approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

@fcollonval fcollonval merged commit f60da4e into jupyterlab:master Oct 6, 2022
@jtpio jtpio deleted the github-reporter branch October 6, 2022 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
maintenance tag:Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @fcollonval