Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel snapshot in test documentation #13295

Merged
merged 1 commit into from Oct 25, 2022
Merged

Fix kernel snapshot in test documentation #13295

merged 1 commit into from Oct 25, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Oct 24, 2022

Revert a snapshot changed by error in #13037

References

Discussion #13037 (comment)

Code changes

None

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.0 milestone Oct 24, 2022
fcollonval
fcollonval approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet

@krassowski
Copy link
Member

#13287 addressed that test being flaky

@fcollonval
Copy link
Member

fcollonval commented Oct 25, 2022 •
edited

Going ahead and merging as CI failures are not related

@fcollonval fcollonval merged commit 919ecbe into jupyterlab:master Oct 25, 2022
@brichet brichet deleted the fix/test_documentation_snapshot branch October 27, 2022 08:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@brichet brichet

Labels
maintenance tag:Testing
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brichet @krassowski @fcollonval