Handle missing user service #13353
Merged
Handle missing user service #13353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of jupyterlab#13337
|
Thanks for making a pull request to jupyterlab! |
hbcarlos
pushed a commit
to hbcarlos/jupyterlab
that referenced
this pull request
Jan 29, 2023
* Handle missing user service Follow-up of jupyterlab#13337 * Set correct fake identity * Fix integrity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up of #13337
Code changes
If request the user information fails, set
readyto an never-resolved promise. So the code does not try to access user information.This is useful if the backend is missing an identity service (like in jupyter-server v1)
User-facing changes
N/A
Backwards-incompatible changes
N/A