Use same key for saving user info in local store #13482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
fcollonval
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Thanks @hbcarlos
One question, does that implies that the user name will be kept between two sessions?
Yes |
|
@meeseeksdev please backport to 3.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Nov 25, 2022
fcollonval
pushed a commit
that referenced
this pull request
Nov 28, 2022
…13488) Co-authored-by: Carlos Herrero <contact@carloshb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using the username as a key to saving the user's identity in local storage, and the username is a randomly generated UUID, every time we remove the cookie, the server will generate a new anonymous user, and instead of removing the old identity and adding the new one to local storage, we are creating a new entry.
See:
References
Code changes
It uses a service ID as a key for saving the user identity in local storage.
User-facing changes
N/A
Backwards-incompatible changes
N/A