Faster rendering of the debugger tree #13707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
Design System CSS
pkg:debugger
tag:CSS
krassowski
force-pushed
the
faster-debugger-tree
branch
from
eff1f1c
to
9daa2eb
Compare
krassowski
force-pushed
the
faster-debugger-tree
branch
from
9daa2eb
to
81ff7d8
Compare
|
please update snapshots |
krassowski
commented
Jan 4, 2023
krassowski
commented
Jan 4, 2023
|
Documentation snapshots updated. |
|
Galata snapshots updated. |
|
please update galata snapshots |
|
please update documentation snapshots |
|
Documentation snapshots updated. |
|
Galata snapshots updated. |
|
Kicking the CI |
krassowski
commented
Jan 5, 2023
krassowski
commented
Jan 5, 2023
fcollonval
reviewed
Jan 5, 2023
|
please update snapshots |
|
Documentation snapshots updated. |
jtpio
reviewed
Jan 16, 2023
krassowski
force-pushed
the
faster-debugger-tree
branch
from
8825c52
to
db717c5
Compare
fcollonval
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Thanks @krassowski
I added two minor suggestions to have a docstring on all props. But those are not mandatory.
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #13694, as a side-effect fixes a bug with multiple loop buttons showing when hovering over nested branches.
UI profiler with default settings for new debugger scenario (jupyterlab/ui-profiler#25):
Before
After
Code changes
VariablesComponenttoVariablesBranch(it was too confusing to navigateVariableComponentandVariablesComponentwhen one is nested in the other, would likely lead to CSS errors with time if left as-is)User-facing changes
Backwards-incompatible changes
Only in CSS styles