Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lumino packages to 2.0.0-beta.0 #13828

Merged
merged 17 commits into from Feb 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 12 additions & 12 deletions builder/package.json
Expand Up @@ -32,18 +32,18 @@
"watch": "tsc -w --listEmittedFiles"
},
"dependencies": {
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/application": "^2.0.0-alpha.6",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/domutils": "^2.0.0-alpha.6",
"@lumino/dragdrop": "^2.0.0-alpha.6",
"@lumino/messaging": "^2.0.0-alpha.6",
"@lumino/properties": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/virtualdom": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6",
"@lumino/algorithm": "^2.0.0-beta.0",
"@lumino/application": "^2.0.0-beta.1",
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/disposable": "^2.0.0-beta.1",
"@lumino/domutils": "^2.0.0-beta.0",
"@lumino/dragdrop": "^2.0.0-beta.1",
"@lumino/messaging": "^2.0.0-beta.0",
"@lumino/properties": "^2.0.0-beta.0",
"@lumino/signaling": "^2.0.0-beta.1",
"@lumino/virtualdom": "^2.0.0-beta.0",
"@lumino/widgets": "^2.0.0-beta.1",
"ajv": "^8.12.0",
"commander": "^9.4.1",
"css-loader": "^6.7.1",
Expand Down
24 changes: 12 additions & 12 deletions dev_mode/package.json
Expand Up @@ -115,18 +115,18 @@
"@jupyterlab/vdom": "~4.0.0-alpha.18",
"@jupyterlab/vdom-extension": "~4.0.0-alpha.18",
"@jupyterlab/vega5-extension": "~4.0.0-alpha.18",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/application": "^2.0.0-alpha.6",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/domutils": "^2.0.0-alpha.6",
"@lumino/dragdrop": "^2.0.0-alpha.6",
"@lumino/messaging": "^2.0.0-alpha.6",
"@lumino/properties": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/virtualdom": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6",
"@lumino/algorithm": "^2.0.0-beta.0",
"@lumino/application": "^2.0.0-beta.1",
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/disposable": "^2.0.0-beta.1",
"@lumino/domutils": "^2.0.0-beta.0",
"@lumino/dragdrop": "^2.0.0-beta.1",
"@lumino/messaging": "^2.0.0-beta.0",
"@lumino/properties": "^2.0.0-beta.0",
"@lumino/signaling": "^2.0.0-beta.1",
"@lumino/virtualdom": "^2.0.0-beta.0",
"@lumino/widgets": "^2.0.0-beta.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"yjs": "^13.5.40"
Expand Down
4 changes: 2 additions & 2 deletions examples/cell/package.json
Expand Up @@ -18,8 +18,8 @@
"@jupyterlab/services": "^7.0.0-alpha.18",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.18",
"@jupyterlab/ui-components": "^4.0.0-alpha.33",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"css-loader": "^6.7.1",
Expand Down
4 changes: 2 additions & 2 deletions examples/console/package.json
Expand Up @@ -15,8 +15,8 @@
"@jupyterlab/services": "^7.0.0-alpha.18",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.18",
"@jupyterlab/translation": "^4.0.0-alpha.18",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"css-loader": "^6.7.1",
Expand Down
24 changes: 12 additions & 12 deletions examples/federated/core_package/package.json
Expand Up @@ -81,18 +81,18 @@
"@jupyterlab/ui-components-extension": "~4.0.0-alpha.18",
"@jupyterlab/vdom-extension": "~4.0.0-alpha.18",
"@jupyterlab/vega5-extension": "~4.0.0-alpha.18",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/application": "^2.0.0-alpha.6",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/domutils": "^2.0.0-alpha.6",
"@lumino/dragdrop": "^2.0.0-alpha.6",
"@lumino/messaging": "^2.0.0-alpha.6",
"@lumino/properties": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/virtualdom": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6",
"@lumino/algorithm": "^2.0.0-beta.0",
"@lumino/application": "^2.0.0-beta.1",
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/disposable": "^2.0.0-beta.1",
"@lumino/domutils": "^2.0.0-beta.0",
"@lumino/dragdrop": "^2.0.0-beta.1",
"@lumino/messaging": "^2.0.0-beta.0",
"@lumino/properties": "^2.0.0-beta.0",
"@lumino/signaling": "^2.0.0-beta.1",
"@lumino/virtualdom": "^2.0.0-beta.0",
"@lumino/widgets": "^2.0.0-beta.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"yjs": "^13.5.40"
Expand Down
2 changes: 1 addition & 1 deletion examples/federated/md_package/package.json
Expand Up @@ -11,7 +11,7 @@
"@jupyterlab/application": "^4.0.0-alpha.18",
"@jupyterlab/example-federated-middle": "^3.0.0-alpha.18",
"@jupyterlab/markdownviewer-extension": "^4.0.0-alpha.18",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0-alpha.18",
Expand Down
2 changes: 1 addition & 1 deletion examples/federated/middle_package/package.json
Expand Up @@ -7,7 +7,7 @@
"clean": "rimraf ../labextensions/@jupyterlab/example-federated-middle"
},
"dependencies": {
"@lumino/coreutils": "^2.0.0-alpha.6"
"@lumino/coreutils": "^2.0.0-beta.0"
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0-alpha.18",
Expand Down
4 changes: 2 additions & 2 deletions examples/filebrowser/package.json
Expand Up @@ -19,8 +19,8 @@
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.18",
"@jupyterlab/translation": "^4.0.0-alpha.18",
"@jupyterlab/ui-components": "^4.0.0-alpha.33",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"css-loader": "^6.7.1",
Expand Down
4 changes: 2 additions & 2 deletions examples/notebook/package.json
Expand Up @@ -21,8 +21,8 @@
"@jupyterlab/services": "^7.0.0-alpha.18",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.18",
"@jupyterlab/translation": "^4.0.0-alpha.18",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"css-loader": "^6.7.1",
Expand Down
2 changes: 1 addition & 1 deletion examples/terminal/package.json
Expand Up @@ -12,7 +12,7 @@
"@jupyterlab/services": "^7.0.0-alpha.18",
"@jupyterlab/terminal": "^4.0.0-alpha.18",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.18",
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/widgets": "^2.0.0-beta.1"
},
"devDependencies": {
"css-loader": "^6.7.1",
Expand Down
6 changes: 3 additions & 3 deletions galata/extension/package.json
Expand Up @@ -39,9 +39,9 @@
"@jupyterlab/nbformat": "^4.0.0-alpha.18",
"@jupyterlab/notebook": "^4.0.0-alpha.18",
"@jupyterlab/settingregistry": "^4.0.0-alpha.18",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6"
"@lumino/algorithm": "^2.0.0-beta.0",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/signaling": "^2.0.0-beta.1"
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0-alpha.18",
Expand Down
2 changes: 1 addition & 1 deletion galata/package.json
Expand Up @@ -51,7 +51,7 @@
"@jupyterlab/notebook": "^4.0.0-alpha.18",
"@jupyterlab/services": "^7.0.0-alpha.18",
"@jupyterlab/settingregistry": "^4.0.0-alpha.18",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-beta.0",
"@playwright/test": "^1.30.0",
"@stdlib/stats": "~0.0.13",
"fs-extra": "^10.1.0",
Expand Down
6 changes: 4 additions & 2 deletions galata/test/benchmark/notebook.spec.ts
Expand Up @@ -140,7 +140,9 @@ test.describe('Benchmark', () => {

// Shutdown the kernel to be sure it does not get in our way (especially for the close action)
await page.click('li[role="menuitem"]:has-text("Kernel")');
await page.click('ul[role="menu"] >> text=Shut Down All Kernels…');
await page.click(
'.lm-Menu ul[role="menu"] >> text=Shut Down All Kernels…'
);
await page.click('button:has-text("Shut Down All") >> nth=-1'); // Click on the last matched button.

// Open text file
Expand Down Expand Up @@ -192,7 +194,7 @@ test.describe('Benchmark', () => {
// Close notebook
await page.click('li[role="menuitem"]:has-text("File")');
const closeTime = await perf.measure(async () => {
await page.click('ul[role="menu"] >> text=Close Tab');
await page.click('.lm-Menu ul[role="menu"] >> text=Close Tab');
// Revert changes so we don't measure saving
const dimissButton = page.locator('button:has-text("Discard")');
if (await dimissButton.isVisible({ timeout: 50 })) {
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion galata/test/documentation/export_notebook.test.ts
Expand Up @@ -24,7 +24,9 @@ test.describe('Export Notebook', () => {
await page.waitForSelector('text=Python 3 (ipykernel) | Idle');

await page.click('text=File');
await page.click('ul[role="menu"] >> text=Save and Export Notebook As');
await page.click(
'.lm-Menu ul[role="menu"] >> text=Save and Export Notebook As'
);

// Wait for Latex renderer
await page.waitForSelector('text=(𝜎σ, 𝛽β, 𝜌ρ)');
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 11 additions & 9 deletions galata/test/documentation/general.test.ts
Expand Up @@ -41,11 +41,11 @@ test.describe('General', () => {
await page.dblclick('text=Lorenz.ipynb');

await page.click('text=File');
await page.click('ul[role="menu"] >> text=New');
await page.click('.lm-Menu ul[role="menu"] >> text=New');
await page.click('#jp-mainmenu-file-new >> text=Terminal');

await page.click('text=File');
await page.click('ul[role="menu"] >> text=New');
await page.click('.lm-Menu ul[role="menu"] >> text=New');
await page.click('#jp-mainmenu-file-new >> text=Console');
await page.click('button:has-text("Select")');

Expand Down Expand Up @@ -200,7 +200,7 @@ test.describe('General', () => {
await page.click('text=File');
await page.mouse.move(70, 40);
const fileMenuNewItem = await page.waitForSelector(
'ul[role="menu"] >> text=New'
'.lm-Menu ul[role="menu"] >> text=New'
);
await fileMenuNewItem.click();

Expand Down Expand Up @@ -269,8 +269,8 @@ test.describe('General', () => {

await page.click('text=File');
await page.mouse.move(70, 40);
await page.click('ul[role="menu"] >> text=New');
await page.hover('ul[role="menu"] >> text=Text File');
await page.click('.lm-Menu ul[role="menu"] >> text=New');
await page.hover('.lm-Menu ul[role="menu"] >> text=Text File');

// Inject mouse
await page.evaluate(
Expand Down Expand Up @@ -322,7 +322,7 @@ test.describe('General', () => {
await page.dblclick('text=jupyterlab.md');

await page.click('text=Settings');
await page.click('ul[role="menu"] >> text=Text Editor Key Map');
await page.click('.lm-Menu ul[role="menu"] >> text=Text Editor Key Map');

expect(
await page.screenshot({ clip: { y: 0, x: 260, width: 600, height: 450 } })
Expand Down Expand Up @@ -426,7 +426,7 @@ test.describe('General', () => {

// Open a terminal
await page.click('text=File');
await page.click('ul[role="menu"] >> text=New');
await page.click('.lm-Menu ul[role="menu"] >> text=New');
await page.click('#jp-mainmenu-file-new >> text=Terminal');

// Wait for the xterm.js element to be added in the DOM
Expand Down Expand Up @@ -455,7 +455,7 @@ test.describe('General', () => {

// Open a terminal
await page.click('text=File');
await page.click('ul[role="menu"] >> text=New');
await page.click('.lm-Menu ul[role="menu"] >> text=New');
await page.click('#jp-mainmenu-file-new >> text=Terminal');

await page.dblclick(
Expand Down Expand Up @@ -529,7 +529,9 @@ test.describe('General', () => {
await page.notebook.run();

await page.click('text=File');
await page.click('ul[role="menu"] >> text=New Console for Notebook');
await page.click(
'.lm-Menu ul[role="menu"] >> text=New Console for Notebook'
);

await page.click('.jp-CodeConsole-input >> .cm-content');
await page.keyboard.type(
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions galata/test/documentation/internationalization.test.ts
Expand Up @@ -17,7 +17,7 @@ test.describe('Internationalization', () => {
await setSidebarWidth(page);

await page.click('text=Settings');
await page.click('ul[role="menu"] >> text=Language');
await page.click('.lm-Menu ul[role="menu"] >> text=Language');

expect(
await page.screenshot({ clip: { y: 5, x: 250, width: 800, height: 600 } })
Expand All @@ -30,7 +30,7 @@ test.describe('Internationalization', () => {
await setSidebarWidth(page);

await page.click('text=Settings');
await page.click('ul[role="menu"] >> text=Language');
await page.click('.lm-Menu ul[role="menu"] >> text=Language');
await page.click('#jp-mainmenu-settings-language >> text=Chinese');

expect(
Expand All @@ -45,7 +45,7 @@ test.describe('Internationalization', () => {
await page.goto();

await page.click('text=Settings');
await page.click('ul[role="menu"] >> text=Language');
await page.click('.lm-Menu ul[role="menu"] >> text=Language');
await page.click('#jp-mainmenu-settings-language >> text=Chinese');

await Promise.all([
Expand Down
4 changes: 2 additions & 2 deletions galata/test/galata/fixture.spec.ts
Expand Up @@ -37,15 +37,15 @@ test.describe('mockSettings', () => {

test('should not return mocked settings after save', async ({ page }) => {
await page.click('text=Settings');
await page.click('ul[role="menu"] >> text=Theme');
await page.click('.lm-Menu ul[role="menu"] >> text=Theme');
const [response] = await Promise.all([
page.waitForResponse(
response =>
/.*api\/settings\/@jupyterlab\/apputils-extension:themes/.test(
response.url()
) && response.request().method() === 'GET'
),
page.click('ul[role="menu"] >> text=JupyterLab Light')
page.click('.lm-Menu ul[role="menu"] >> text=JupyterLab Light')
]);

await page.waitForSelector('#jupyterlab-splash', { state: 'detached' });
Expand Down
4 changes: 3 additions & 1 deletion galata/test/jupyterlab/contextmenu.test.ts
Expand Up @@ -110,7 +110,9 @@ test.describe('Application Context Menu', () => {
expect(await page.menu.isAnyOpen()).toBe(true);

await page.hover('text=Open With');
await page.waitForSelector('li[role="menuitem"]:has-text("Editor")');
await page.waitForSelector(
'.lm-Menu li[role="menuitem"]:has-text("Editor")'
);

const imageName = `file-openwith.png`;
// Get the last menu -> will be submenu
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion jupyterlab/tests/mock_packages/interop/token/package.json
Expand Up @@ -3,6 +3,6 @@
"version": "4.0.0-alpha.18",
"private": true,
"dependencies": {
"@lumino/coreutils": "^2.0.0-alpha.6"
"@lumino/coreutils": "^2.0.0-beta.0"
}
}
2 changes: 1 addition & 1 deletion jupyterlab/tests/mock_packages/mimeextension/package.json
Expand Up @@ -3,7 +3,7 @@
"version": "0.3.0",
"private": true,
"dependencies": {
"@lumino/widgets": "^2.0.0-alpha.6"
"@lumino/widgets": "^2.0.0-beta.1"
},
"jupyterlab": {
"mimeExtension": true
Expand Down
6 changes: 3 additions & 3 deletions package.json
Expand Up @@ -104,9 +104,9 @@
"watch:packages": "python scripts/watch_packages.py"
},
"resolutions": {
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/disposable": "^2.0.0-beta.0",
"@lumino/signaling": "^2.0.0-beta.0",
"@types/react": "^18.0.26",
"react": "^18.2.0",
"yjs": "^13.5.40"
Expand Down
10 changes: 5 additions & 5 deletions packages/application-extension/package.json
Expand Up @@ -46,11 +46,11 @@
"@jupyterlab/statusbar": "^4.0.0-alpha.18",
"@jupyterlab/translation": "^4.0.0-alpha.18",
"@jupyterlab/ui-components": "^4.0.0-alpha.33",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6",
"@lumino/algorithm": "^2.0.0-beta.0",
"@lumino/commands": "^2.0.0-beta.1",
"@lumino/coreutils": "^2.0.0-beta.0",
"@lumino/disposable": "^2.0.0-beta.1",
"@lumino/widgets": "^2.0.0-beta.1",
"react": "^18.2.0"
},
"devDependencies": {
Expand Down