Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link nbclassic docs, note Lab 4 drop notebook dependency #13830

Merged
merged 3 commits into from Jan 27, 2023

Conversation

RRosio
Copy link
Contributor

@RRosio RRosio commented Jan 21, 2023

References

Updating docs to as mentioned in #12115

Code changes

Adds a few sentences in documentation offering links to NbClassic documentation which informs users about using JupyterLab, Notebook and NbClassic. Also, mentions the drop in Notebook dependency as of Lab 4.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented Jan 21, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio jtpio added this to the 4.0.0 milestone Jan 22, 2023
@jtpio
Copy link
Member

jtpio commented Jan 22, 2023

Thanks!

@@ -85,4 +85,10 @@ We appreciate feedback on our `GitHub issues page <https://github.com/jupyterlab
as we evolve towards a stable extension development API.

JupyterLab will eventually replace the classic Jupyter Notebook.
Throughout this transition, the same notebook document format will be supported by both the classic Notebook and JupyterLab.
Throughout this transition, the same notebook document format will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JupyterLab will eventually replace the classic Jupyter Notebook.

Wondering if the sentence above is still valid? With the current state of the projects Notebook 7 will be the one replacing the classic notebook 6.

Copy link
Member

@jtpio jtpio Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's true we should indeed still mention JupyterLab 4 will not have the notebook dependency 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I think that sentence could be changed to better reflect the state of projects today. I have made some updates which I thought might fit better, but I would appreciate feedback on them!

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 1250d94 into jupyterlab:master Jan 27, 2023
@welcome
Copy link

welcome bot commented Jan 27, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants