New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link nbclassic docs, note Lab 4 drop notebook dependency #13830
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks! |
@@ -85,4 +85,10 @@ We appreciate feedback on our `GitHub issues page <https://github.com/jupyterlab | |||
as we evolve towards a stable extension development API. | |||
|
|||
JupyterLab will eventually replace the classic Jupyter Notebook. | |||
Throughout this transition, the same notebook document format will be supported by both the classic Notebook and JupyterLab. | |||
Throughout this transition, the same notebook document format will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JupyterLab will eventually replace the classic Jupyter Notebook.
Wondering if the sentence above is still valid? With the current state of the projects Notebook 7 will be the one replacing the classic notebook 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's true we should indeed still mention JupyterLab 4 will not have the notebook
dependency 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I think that sentence could be changed to better reflect the state of projects today. I have made some updates which I thought might fit better, but I would appreciate feedback on them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Updating docs to as mentioned in #12115
Code changes
Adds a few sentences in documentation offering links to NbClassic documentation which informs users about using JupyterLab, Notebook and NbClassic. Also, mentions the drop in Notebook dependency as of Lab 4.