Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use singleton boolean type for codemirror lineWiseCopyCut setting #14055

Merged
merged 1 commit into from Feb 21, 2023
Merged

use singleton boolean type for codemirror lineWiseCopyCut setting #14055

merged 1 commit into from Feb 21, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 21, 2023 •
edited by fcollonval

References

Fixes #14011

Code changes

  • replaces use of ["boolean"] as a type in schema

User-facing changes

  • when opening CodeMirror in Advanced Settings Editor it shouldn't go to the classic "react snowstorm"

Backwards-incompatible changes

  • n/a

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl marked this pull request as ready for review February 21, 2023 00:22
@andrii-i
Copy link
Contributor

andrii-i commented Feb 21, 2023 •
edited

advanced_settings_editor

@fcollonval fcollonval added the bug label Feb 21, 2023
@fcollonval fcollonval added this to the 3.6.x milestone Feb 21, 2023
fcollonval
fcollonval approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit bc1962d into jupyterlab:master Feb 21, 2023
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@meeseeksmachine meeseeksmachine mentioned this pull request Feb 21, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Feb 21, 2023
@bollwyvl @meeseeksmachine
Backport PR jupyterlab#14055: use singleton boolean type for codemirr…
102e35e 
…or `lineWiseCopyCut` setting
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 481 <- [510 - 525 - 537] -> 616 979 <- [1033 - 1053 - 1074] -> 1178
expected 479 <- [509 - 523 - 540] -> 691 966 <- [1025 - 1049 - 1061] -> 1186
Mean relative change -0.4% ± 1.4% 0.6% ± 1.1%
switch-from
chromium
actual 597 <- [687 - 699 - 711] -> 799 288 <- [349 - 366 - 386] -> 433
expected 600 <- [678 - 696 - 707] -> 943 272 <- [354 - 372 - 389] -> 426
Mean relative change 0.3% ± 1.4% -1.0% ± 2.3%
switch-to
chromium
actual 1159 <- [1274 - 1323 - 1339] -> 1454 779 <- [890 - 912 - 940] -> 1036
expected 1205 <- [1291 - 1325 - 1346] -> 1462 817 <- [890 - 909 - 943] -> 1051
Mean relative change -0.7% ± 1.1% -0.2% ± 1.2%
close
chromium
actual 130 <- [141 - 145 - 148] -> 165 174 <- [197 - 204 - 212] -> 243
expected 129 <- [138 - 142 - 146] -> 163 170 <- [197 - 205 - 212] -> 236
Mean relative change 2.1% ± 1.2% 0.1% ± 1.7%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: +145 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentString 1 +79 B
Detached Text 1 +64 B
ResizeHandle 1 +47 B
Set 1 +137 B
Signal 1 +38 B
UndoManager 1 +1.41 kB
YArray 1 +164 B
YText 1 +314 B
Detached DOMStringMap 2 +96 B
Detached V8EventHandlerNonNull 2 +80 B
StackItem 2 +952 B
YMap 2 +464 B
ContentType 4 +273 B
DeleteItem 4 +80 B
DeleteSet 4 +720 B
StyleModule 4 +128 B
ContentAny 5 +254 B
Detached HTMLCollection 6 +564 B
EventHandler 8 +256 B
ID 10 +320 B
Item 10 +1.42 kB
Map 11 +1.77 kB
Detached Attr 13 +936 B
Detached DOMTokenList 13 +868 B
Detached HTMLDivElement 13 +45 kB
Array 41 +14 kB
Detached V8EventListener 262 +21.9 kB
(closure) 264 +26.7 kB
Detached EventListener 264 +41 kB
Detached InternalNode 318 +43.5 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +4 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +1 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +1 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Create a markdown cell Memory change: +192 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +450 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +9 B
AttachmentsResolver 1 +14 B
ContentString 1 +76 B
Debouncer 1 +3.47 kB
Detached HTMLAnchorElement 1 +288 B
Detached HTMLButtonElement 1 +5.24 kB
Detached HTMLHeadingElement 1 +920 B
Error 1 +3.03 kB
MarkdownCell 1 +4.69 kB
MarkdownCellModel 1 +381 B
Poll 1 +3.45 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +66 B
Transaction 1 +876 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YMarkdownCell 1 +137 B
Detached CSSStyleDeclaration 2 +116 B
Detached HTMLElement 2 +288 B
Detached V8EventHandlerNonNull 2 +4.99 kB
ObservableMap 2 +256 B
Promise 2 +3.07 kB
PromiseDelegate 2 +3.29 kB
StackItem 2 +932 B
UndoManager 2 +1.79 kB
YText 2 +534 B
DeleteItem 3 +60 B
Detached DOMStringMap 3 +120 B
DeleteSet 4 +700 B
YMap 4 +872 B
ContentAny 5 +524 B
ContentType 7 +718 B
Detached Text 7 +448 B
Set 8 +733 B
StyleModule 8 +256 B
Detached HTMLDivElement 10 +30.1 kB
Detached DOMTokenList 13 +752 B
ID 13 +416 B
Item 13 +2.4 kB
EventHandler 14 +448 B
Detached HTMLCollection 17 +1.68 kB
Signal 20 +342 B
Map 23 +3.52 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.4 kB
(closure) 151 +51.3 kB
Detached InternalNode 162 +28 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [687c64ae-166e-433c-a350-241b37695033, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2289:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +8 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Create a raw cell Memory change: +117 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentString 1 +79 B
Detached CSSStyleDeclaration 1 +52 B
Detached V8EventHandlerNonNull 1 +40 B
YArray 1 +164 B
Detached DOMStringMap 2 +80 B
Set 2 +273 B
StackItem 2 +932 B
UndoManager 2 +1.71 kB
YText 2 +534 B
DeleteItem 3 +60 B
DeleteSet 4 +700 B
YMap 4 +872 B
ContentAny 5 +454 B
Detached HTMLCollection 5 +452 B
ContentType 7 +718 B
StyleModule 7 +224 B
Detached DOMTokenList 9 +520 B
Detached HTMLDivElement 9 +22.5 kB
ID 13 +416 B
Item 13 +2.33 kB
EventHandler 14 +448 B
Map 15 +2.54 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +16.9 kB
Detached InternalNode 151 +21.5 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [180c97d0-6f18-42dc-84f6-73c400e503b2, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2289:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +7 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
✔ Adding a cell (234644ms) - Drag and drop a cell

File editor memory leaks

Create a file Memory change: -88.8 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.31 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.7 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +82 B
LabIcon 2 +1.08 kB
Detached CSSStyleDeclaration 3 +224 B
Detached HTMLLIElement 3 +5.04 kB
Detached NodeList 3 +188 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +109 B
Detached SVGGElement 4 +2.94 kB
StyleModule 4 +661 B
VirtualElement 4 +3.45 kB
Detached HTMLSpanElement 5 +2.1 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.77 kB
Detached SVGSVGElement 5 +7.95 kB
Detached DOMStringMap 7 +376 B
Detached SVGAnimatedNumber 7 +448 B
Detached Text 9 +664 B
Detached Attr 10 +720 B
Detached DOMTokenList 13 +844 B
Detached HTMLCollection 13 +1.42 kB
Detached HTMLDivElement 15 +32.9 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +-7.29 kB

Leaking collections:

Type Change Preview Size increased at
Array +4 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:73:11          
  webpack://jupyterlab/packages/fileeditor/src/widget.ts:219:13          
  webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
✔ Opening a text file (72005ms)

Notebook memory leaks

Create a notebook Memory change: +26.6 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.19 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +55 B
Detached HTMLButtonElement 2 +23.4 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +-785 B
LabIcon 2 +67 B
Detached CSSStyleDeclaration 3 +256 B
Detached HTMLLIElement 3 +5.65 kB
Detached NodeList 3 +240 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +107 B
VirtualElement 4 +1.11 kB
Detached HTMLSpanElement 5 +2.79 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.28 kB
Detached SVGGElement 6 +4.9 kB
Detached SVGPathElement 7 +2.47 kB
StyleModule 8 +789 B
Detached SVGAnimatedNumber 9 +576 B
Detached Text 9 +628 B
Detached Attr 10 +720 B
Detached HTMLCollection 13 +1.32 kB
Detached DOMTokenList 14 +884 B
Detached HTMLDivElement 15 +33.2 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 137 +40.6 kB

Leaking collections:

Type Change Preview Size increased at
Array +8 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
✔ Opening a notebook (76266ms)

3 passing (6m)
1 pending

fcollonval pushed a commit that referenced this pull request Feb 21, 2023
@meeseeksmachine @bollwyvl
Backport PR #14055: use singleton boolean type for codemirror `lineWi…
cf52389 
…seCopyCut` setting (#14059)

Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@bollwyvl bollwyvl

Labels
bug pkg:codemirror
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.

Clicking CodeMirror tile or accordion in Settings Editor breaks rightmost section of Settings Editor
3 participants
@bollwyvl @andrii-i @fcollonval