Activate the deferred plugins after shell restore #14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
fcollonval
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks @brichet
I have some comments and I think we should wait for a new release of lumino with the related change. As the behavior of deferred extensions is gonna changed, I would prefer to have it in a new minor version.
|
Test failure does not appear to be linked to this PR. |
brichet
force-pushed
the
deferred_plugins
branch
from
551a3eb
to
d763592
Compare
github-actions
bot
removed
pkg:extensionmanager
pkg:attachments
pkg:observables
tag:Testing
pkg:statusbar
pkg:ui-components
pkg:htmlviewer
pkg:documentsearch
pkg:logconsole
pkg:celltags
pkg:property-inspector
pkg:settingregistry
pkg:statedb
pkg:toc
pkg:debugger
pkg:translation
pkg:cell-toolbar
pkg:lsp
labels
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
… add tests on plugin activation
brichet
force-pushed
the
deferred_plugins
branch
from
388c9e2
to
3f163d6
Compare
|
Thanks @brichet merging this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves pageload time by deferring the activation of huge extensions.
After the shell restore, activates the plugins that have been deferred from:
page_config.json, currently they are not activated at all if not required by another plugindeferredcoming from Add a 'defer' option to the autoStart argument lumino#588References
Fixes #14576
Related to jupyterlab/lumino#588
Code changes
The changes are in
JupyterLabclass.User-facing changes
Activation of a plugin containing a 5s sleep:
Backwards-incompatible changes
This is currently backward compatible but I used
// @ts-ignoreto avoid error at compilation.There may be better implementation for it.