Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style validator #14795

Merged
merged 6 commits into from Jul 17, 2023
Merged

Conversation

krassowski
Copy link
Member

References

Fixes #14794, includes #14789

Code changes

Adds stylelint-csstree-validator for CSS validation, fixes invalid values in CSS styles.

User-facing changes

Backwards-incompatible changes

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

I agree with you that the animation for the shortcut editor is not great. Feel free to remove it or not before merging.

@fcollonval fcollonval merged commit c68fa8e into jupyterlab:main Jul 17, 2023
75 of 77 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 17, 2023
fcollonval pushed a commit that referenced this pull request Jul 18, 2023
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@t03857785
Copy link
Contributor

Looks like the CSS changes in #14766 and #14854 will not pass the stylelint-csstree-validator validation as it does not allow the use of min, max or calc in place of exact values, not sure there is an easy way to replace these do we just want to use exceptions for these

@fcollonval
Copy link
Member

@t03857785 please use a ignore line rule and if possible link to the csstree issue: csstree/csstree#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid CSS styles - CSS validator needed
3 participants