Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds this context when calling ICompletionProvider.modelFactory #14812

Merged
merged 2 commits into from Jul 18, 2023
Merged

Adds this context when calling ICompletionProvider.modelFactory #14812

merged 2 commits into from Jul 18, 2023

Conversation

hbcarlos
Copy link
Member

References

Fixes #14805

Code changes

See #14805

User-facing changes

N/A

Backwards-incompatible changes

N/A

@hbcarlos hbcarlos added the bug label Jul 11, 2023
@hbcarlos hbcarlos requested a review from krassowski July 11, 2023 14:01
@hbcarlos hbcarlos self-assigned this Jul 11, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

krassowski
krassowski reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth modifying tests to test this?

@hbcarlos hbcarlos requested a review from krassowski July 13, 2023 13:38
@krassowski krassowski added this to the 4.0.x milestone Jul 13, 2023
krassowski
krassowski approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hbcarlos!

fcollonval
fcollonval approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit 3e45cb9 into jupyterlab:main Jul 18, 2023
76 of 81 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jul 18, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 18, 2023
@hbcarlos @meeseeksmachine
Backport PR jupyterlab#14812: Adds this context when calling IComplet…
7140a54 
…ionProvider.modelFactory
@hbcarlos hbcarlos deleted the fix_#14805 branch July 18, 2023 13:01
fcollonval pushed a commit that referenced this pull request Jul 19, 2023
@meeseeksmachine @hbcarlos
Backport PR #14812: Adds this context when calling ICompletionProvide…
2501ff9 
…r.modelFactory (#14843)

Co-authored-by: Carlos Herrero <26092748+hbcarlos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees

@hbcarlos hbcarlos

Labels
bug pkg:completer
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

this context gets lost in modelFactory
3 participants
@hbcarlos @fcollonval @krassowski