Refactor of Notebook and Console Content Factories #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
force-pushed
the
cellfactory
branch
from
3015cf9
to
e36d609
Compare
afshin
approved these changes
Jan 17, 2017
| // Set the completer widget's anchor node to peg its position. | ||
| this._completer.anchor = this.node; | ||
|
|
||
| // Because a completer widget may be passed in, check if it is attached. |
There was a problem hiding this comment.
This comment (and the attachment check) are no longer relevant.
| rawCellContentFactory?: BaseCellWidget.IContentFactory; | ||
|
|
||
| /** | ||
| * The factory for console wiget content. If given, this will |
| // Set up the completer handler. | ||
| this._completerHandler = new CellCompleterHandler({ | ||
| // Because a completer widget may be passed in, check if it is attached. | ||
| if (!this._completer.isAttached) { |
There was a problem hiding this comment.
Same as with console, this attachment check is no longer necessary.
blink1073
changed the title
|
Not sure why Appveyor refused to build the last commit. It was right about the time I enabled my own fork on Appveyor, so I suspect it was a glitch. |
|
Epic 👍 |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
IRenderertoIContentFactoryand cleans up implementation and naming consistency down the line across Console and Notebook/Cell/Output Area.Fixes #905. Fixes #1415. Fixes #1414.
The intent of this PR is to enable dependency injection of lower-level components into a hierarchy without subclassing any of the intermediate components. For example, one can inject a custom output area from the notebook panel level.