Fix CodeMirror theme selection background color #14841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
Congrats on your first merged pull request in this project! 🎉 |
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 20, 2023
fcollonval
pushed a commit
that referenced
this pull request
Jul 23, 2023
…14864) Co-authored-by: Allan Chain <36528777+AllanChain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #14737
Code changes
Update the CSS selector for the selection background color.
Previously, the rule from the base CodeMirror6 theme
.cm-focused > .cm-scroller > .cm-selectionLayer .cm-selectionBackgroundtakes precedence over our.cm-focused .cm-selectionBackgroundrule, so the theme selection color is not taking effect. Changing the selector to be the same as the base theme fixes the issue.User-facing changes
Backwards-incompatible changes
None.