Make the browser check default_url configurable
#14944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
Opened #14947 to track flaky UI tests. Restarting the failing check. |
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 11, 2023
fcollonval
pushed a commit
that referenced
this pull request
Aug 11, 2023
…#14949) Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
|
Looks like this is not enough to work out of the box, as the browser check tries to find a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This will allow using
python -m jupyterlab.browser_checkfor other JupyterLab apps like Notebook 7.Code changes
Make
BrowserApp.default_urlconfigurable.User-facing changes
Usage:
python -m jupyterlab.browser_check --BrowserApp.default_url='/tree'Backwards-incompatible changes
None