Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable language server auto-detection to speed up tests on CI #15061

Merged
merged 1 commit into from Sep 4, 2023

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Sep 1, 2023

References

This was noted in jupyter/nbdime#664 (comment), let's see how much of a boost we can get on JupyterLab CI

Code changes

Disables LSP server auto-detection for unrelated unit tests

Tests which use server include:

  • services
  • notebook
  • outputarea
  • debugger

User-facing changes

None

Backwards-incompatible changes

Downstream reusing server start script in tests and relying on LSP will need to adjust their config, but this is very hypothetical (even LSP extension does not do that).

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member Author

No noticeable speedup. Probably this is because gains are much larger on Windows. I guess we can still merge it as it makes the test output cleaner - no more debug messages like:

[D 2023-09-01 16:01:51.854 ServerApp] Checking for /opt/hostedtoolcache/Python/3.11.4/x64/lib/node_modules/bash-language-server/bin/main.js
[D 2023-09-01 16:01:51.854 ServerApp] Checking for /opt/hostedtoolcache/Python/3.11.4/x64/node_modules/bash-language-server/bin/main.js
[D 2023-09-01 16:01:51.854 ServerApp] Checking for /opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/bash-language-server/bin/main.js
[D 2023-09-01 16:01:51.854 ServerApp] Checking for /opt/hostedtoolcache/node/18.17.1/x64/node_modules/bash-language-server/bin/main.js
[D 2023-09-01 16:01:51.855 ServerApp] bash-language-server/bin/main.js not found in node_modules of [PosixPath('/home/runner/work/jupyterlab/jupyterlab/packages/services'), PosixPath('/opt/hostedtoolcache/Python/3.11.4/x64/share/jupyter/lab/staging'), PosixPath('/opt/hostedtoolcache/Python/3.11.4/x64/lib'), PosixPath('/opt/hostedtoolcache/Python/3.11.4/x64'), PosixPath('/opt/hostedtoolcache/node/18.17.1/x64/lib'), PosixPath('/opt/hostedtoolcache/node/18.17.1/x64')]

@krassowski krassowski marked this pull request as ready for review September 1, 2023 18:49
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 6af8fcd into jupyterlab:main Sep 4, 2023
78 of 81 checks passed
@jtpio jtpio added this to the 4.1.0 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants