Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React on galata update comment, fix binder URL in docs #15070

Merged
merged 2 commits into from Sep 4, 2023

Conversation

krassowski
Copy link
Member

References

This is a small developer UX proposal to add +1 reaction (as dependabot does).

Code changes

  • Add a reaction step in galata-update
  • Fixes outdated references to master branch seen when updating docs

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski added this to the 4.0.x milestone Sep 3, 2023
@jtpio jtpio merged commit c570641 into jupyterlab:main Sep 4, 2023
77 of 80 checks passed
@jtpio
Copy link
Member

jtpio commented Sep 4, 2023

@meeseeksdev please backport to 4.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 4, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c570641c70899b83e5cbf93e8fad8bb275c4be85
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15070: React on galata update comment, fix binder URL in docs'
  1. Push to a named branch:
git push YOURFORK 4.0.x:auto-backport-of-pr-15070-on-4.0.x
  1. Create a PR against branch 4.0.x, I would have named this PR:

"Backport PR #15070 on branch 4.0.x (React on galata update comment, fix binder URL in docs)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

krassowski added a commit to krassowski/jupyterlab that referenced this pull request Sep 4, 2023
)

* Let commenter know that the bot invocation worked

* Update docs, also fix some old master references

(cherry picked from commit c570641)
krassowski added a commit that referenced this pull request Sep 6, 2023
* Let commenter know that the bot invocation worked

* Update docs, also fix some old master references

(cherry picked from commit c570641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants