Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text wrapping in the search box #15080

Merged
merged 2 commits into from Oct 10, 2023

Conversation

eliaslma
Copy link
Contributor

@eliaslma eliaslma commented Sep 5, 2023

References

A step towards #15049

The search box wraps long text, which is undesirable because it is very confusing when multi-line search is used.

264590626-fc8ad7ee-e237-4e4d-8852-ed74c9fb1815

Code changes

Added CSS property to the input that handles white spaces following MDN Web Docs.

User-facing changes

Screencast.from.05-09-2023.18.11.27.webm

Context

Browser: Firefox
JupyterLab version: 4.1.0a1

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented Sep 5, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions github-actions bot added pkg:documentsearch tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Sep 5, 2023
@krassowski krassowski added the bug label Sep 6, 2023
@krassowski
Copy link
Member

krassowski commented Sep 6, 2023

Thank you @eliaslma for opening a PR! This helps, and should be included, though is still not ideal because:

  • the overlay scrollbar makes it hard to click on a specific letter (instead, if clicking on the lower half it scrolls over there) - this is browser dependent behaviour
  • the longer text is not visible even if the box could be grown to accommodate the longer text.

Would you be open to also implementing the logic changes for growing the width of the textarea suggested in #15049 (comment)?

@krassowski krassowski added this to the 4.0.x milestone Sep 6, 2023
@krassowski krassowski changed the title Fix text wrapping in the search box- Ref #15049 Fix text wrapping in the search box Sep 14, 2023
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in as an incremental improvement.

Thank you @eliaslma!

@krassowski krassowski merged commit 6646779 into jupyterlab:main Oct 10, 2023
77 of 82 checks passed
@welcome
Copy link

welcome bot commented Oct 10, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Design System CSS pkg:documentsearch tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants