Remove unusedDocuments, fix culling of foreign documents
#15105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
fcollonval
approved these changes
Sep 12, 2023
| document.remainingLifetime -= 1; | ||
| if (document.remainingLifetime <= 0) { | ||
| document.dispose(); | ||
| const ids = documentIDs.get(document)!; | ||
| for (const id of ids) { | ||
| this.foreignDocuments.delete(id); |
There was a problem hiding this comment.
Should we add a test for this case?
These were needed in LSP because it subclasses `VirtualDocument`, but are not needed upstream in JupyterLab itself.
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 14, 2023
…f foreign documents
fcollonval
pushed a commit
that referenced
this pull request
Sep 18, 2023
…documents (#15121) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow up to #12534
Developed in response to a failing test caught on jupyter-lsp/jupyterlab-lsp#978
Code changes
unusedDocumentsis removed (it was never written to since Integratejupyterlab-lspintojupyterlab#12534, it was functioning properly with different logic in lsp extension)closeExpiredDocuments()without need to keep state on theVirtualDocumentinstanceUser-facing changes
When user creates a markdown or raw cell and then deletes it (without other cells of this type present), the connection to LSP server is not held indefinitely but culled after six further document changes.
Backwards-incompatible changes
Removal of the protected
unusedDocumentsmethod is notable but we are not advertising LSP as stable yet, and it would be useless in the current state anyways so it should be fine.