Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a valid email in update extension #15133

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add a valid email in update extension #15133

merged 2 commits into from
Sep 18, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 18, 2023 •
edited
Loading

This PR fixes the usage test, which currently fails while upgrading the mock extension.

References

Probably since jupyterlab/extension-template#43, which requires a valid email pattern.

Error: https://github.com/jupyterlab/jupyterlab/actions/runs/6221683949/job/16884129806

Code changes

None

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

fcollonval
fcollonval requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @brichet

I have a minor suggestion.

jupyterlab/upgrade_extension.py Outdated Show resolved Hide resolved
@brichet @fcollonval
Update jupyterlab/upgrade_extension.py
acc1d32 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fcollonval
fcollonval approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet

@fcollonval fcollonval added this to the 4.0.x milestone Sep 18, 2023
@fcollonval fcollonval merged commit 5412700 into jupyterlab:main Sep 18, 2023
76 of 78 checks passed
@fcollonval fcollonval deleted the fix_upgrade_extension branch September 18, 2023 14:43
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 18, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Sep 18, 2023
@brichet @meeseeksmachine
Backport PR jupyterlab#15133: Add a valid email in update extension
145ac19
krassowski added a commit that referenced this pull request Sep 18, 2023
@meeseeksmachine @brichet @krassowski
Backport PR #15133: Add a valid email in update extension (#15134)
0e152ea 
Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@brichet brichet

Labels
maintenance
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brichet @fcollonval