Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-commit job #15154

Merged
merged 1 commit into from Sep 26, 2023
Merged

Remove pre-commit job #15154

merged 1 commit into from Sep 26, 2023

Conversation

fcollonval
Copy link
Member

References

Follow-up of #15122

Code changes

Remove pre-commit job as done in #13562 for 4.x

That step is not reliable and it is duplicating the job using the pre-commit app.

@fcollonval fcollonval added this to the 3.6.x milestone Sep 25, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

krassowski
krassowski approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit b86cc20 into 3.6.x Sep 26, 2023
69 of 72 checks passed
@fcollonval fcollonval deleted the fcollonval-patch-1 branch September 26, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@fcollonval fcollonval

Labels
maintenance
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @krassowski