Remove hard coded text-plain in multiple places #15182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Oct 3, 2023
packages/codemirror/src/language.ts
Outdated
| @@ -27,7 +27,7 @@ export class EditorLanguageRegistry implements IEditorLanguageRegistry { | |||
| // Add default language text/plain -> No expressions to parse | |||
| this.addLanguage({ | |||
| name: 'none', | |||
| mime: 'text/plain', | |||
| mime: IEditorMimeTypeService.defaultMimeType, | |||
There was a problem hiding this comment.
I am not sure about this one. It could have unexpected consequences if someone changes defaultMimeType downstream.
There was a problem hiding this comment.
I add that parser it to avoid weird highlight with the default mimetype. But I agree that changing this feels weird. Let's keep it hard coded.
fcollonval
commented
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up of #15175
I searched for hard-coded places of
text/plainand remove those not making sense (reviewers please don't hesitate to challenge that statement)Code changes
Remove hard-coded
text/plainby the default mime type constant.User-facing changes
None
Backwards-incompatible changes
None