New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom kernel message serializer #15254
Custom kernel message serializer #15254
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DonJayamanne, this looks good to me!
@krassowski |
Addding a unit test ensuring that the serializer can actually be changed can help catch regression if this function gets rewritten (all it takes to break it is to move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DonJayamanne
I agree that it will be nice to test providing custom de/serializers in a test.
References
Fixes #15198
Code changes
Exposes the message serializer in the ISettings, allowing one to customize how messages are serialized/deserialized based on the server (settings).
User-facing changes
N/A
Backwards-incompatible changes
N/A